release: v0.13.5#47
Merged
Merged
Conversation
Upgrade the ACP schema to v0.13.5 and regenerate bindings. The v0.13.5 protocol release removed the never-stabilized, unstable-only `session/set_model` method (and SetSessionModelRequest/Response, ModelId, ModelInfo, SessionModelState, and the `models` fields on session responses). Model selection is not going away: it now flows through the generic, stable `session/set_config_option` framework via the "model" config-option category. Hand-edited (non-generated) follow-ups to keep the tree compiling: - example/agent/main.go: drop the now-removed UnstableSetSessionModel impl - acp_test.go: drop the UnstableSetSessionModel func field and method Upstream rationale: agentclientprotocol/agent-client-protocol#1325 ("Session config options have been around long enough, so cleaning up the old iteration.") and #1324. Change-Id: I897316b046c99627fc93ca997231c3b9ec625cbe Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Thomas Kosiewski <tk@coder.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the ACP schema to v0.13.5 (
make release VERSION=0.13.5) and regenerates the Go bindings.session/set_modelis gone — but model selection is notThe 0.13.5 protocol release removed the unstable-only session model API:
session/set_modelmethodSetSessionModelRequest/SetSessionModelResponseModelId,ModelInfo,SessionModelState(availableModels/currentModelId)modelsfields on session responsesThis is not functionality being removed — it has moved. Model selection now
flows through the generic, stable
session/set_config_optionframework, wherea session config option carries a semantic
categoryof"model"("Model selector"),alongside the
modeandthought_levelcategories. The same uniform "session configoptions" API now covers model, mode, and reasoning-level selection instead of a bespoke
method per selectable thing.
Concretely, instead of
session/set_model, a client now:configOptions(aSessionConfigSelectwithcurrentValue+options) wherecategory == "model".session/set_config_option { sessionId, configId, value }to switch model.configOptionsback (and may getconfig_option_updateviasession/update).session/set_config_optionand theSessionConfigOptionCategoryenum already existedin v0.13.4 and are unchanged by this bump — 0.13.5 simply retired the redundant
experimental path.
acp.SessionConfigOptionCategoryModelis present in the regeneratedtypes_gen.go.Upstream rationale (maintainer)
From the upstream PR that removed it:
And the doc line added by that PR:
A companion PR removed the dedicated model/mode APIs from the draft v2 protocol too —
so there is no separate "v2" model API; v2 also routes through session config options.
Impact
Because the model API was never stabilized (it only ever lived in
schema.unstable.json),no stable surface breaks. The only affected code is anything implementing/calling the
experimental
UnstableSetSessionModel*symbols.Changes
types_gen.go,agent_gen.go,client_gen.go,constants_gen.go, schema JSON,README.md, version files.example/agent/main.go— dropped the now-removedUnstableSetSessionModelimplementation.acp_test.go— dropped theUnstableSetSessionModelFuncfield and its method.Verification
make test(go test ./...+go build ./example/...) passes.example/client↔example/agentend-to-end ACP session over stdio: Initialize → NewSession → Prompt → permission round-trip → end-of-turn, exit 0.session/set_modelnow returns-32601 Method not found, while a still-supported method (initialize) returns a normal result.🤖 Generated with Claude Code