refactor: replace Nix flake with mise#45
Merged
Conversation
Drop the Nix devshell/flake in favor of mise for toolchain management. Tasks stay in the Makefile, which now calls treefmt/gofumpt directly instead of `nix fmt` / `nix flake check`. - Add mise.toml (+ mise.lock) provisioning Go, gopls, golangci-lint, gofumpt, treefmt, actionlint, zizmor, mdformat (uv) and mdsh (cargo). - Add treefmt.toml replacing the treefmt config previously inlined in flake.nix (gofmt, mdsh, mdformat, actionlint, zizmor; nixfmt dropped). - Makefile: `fmt` -> treefmt, `check` -> treefmt --fail-on-change. - CI: swap the Nix setup/cache steps for jdx/mise-action. - Remove the nix dependabot ecosystem; update AGENTS.md/RELEASING.md. - Delete flake.nix and flake.lock. Change-Id: I4b371372980065cfe309e23d2c9366df76d4717f Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Thomas Kosiewski <tk@coder.com>
treefmt runs both mdsh and mdformat over README.md. The cargo-built mdsh 0.7.0 strips the blank line after an mdsh directive comment, while mdformat re-adds it. Each rewrites the file, so the net content is unchanged (README is a fixpoint of the pair) but treefmt's --fail-on-change trips on the intermediate churn, failing CI. Format in place with treefmt and let 'git diff --exit-code' verify there is no net drift, which still catches genuine formatting/sync regressions while tolerating the harmless oscillation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drops the Nix devshell/flake in favor of mise for toolchain management. Tasks stay in the
Makefile, which now callstreefmt/gofumptdirectly instead ofnix fmt/nix flake check.What changed
mise.toml(+mise.lock) — provisions the toolchain the flake's devshell used to: Go, gopls, golangci-lint, gofumpt, treefmt, actionlint, zizmor, plus mdformat (viauv/pipx) and mdsh (via cargo).mise installsets it all up. The lockfile pins exact versions + checksums for all platforms (incl. the Linux CI runners) for reproducible installs.treefmt.toml— replaces the treefmt config that was inlined inflake.nix(gofmt, mdsh, mdformat, actionlint, zizmor).nixfmtdropped since there are no more.nixfiles. mdsh runs before mdformat (priority) so the README stays in sync.Makefile—make fmt→treefmt;make check→treefmt --fail-on-change(treefmt now runs mdsh + mdformat, so it also validatesREADME.md, replacing the oldmdsh --frozenguard); codegen uses the mise-providedgofumpt..github/workflows/ci.yaml) — replaces the Nix install/cache steps withjdx/mise-action; runsmake checkandmake testthrough mise.nixecosystem.AGENTS.md/RELEASING.mdnow reference mise instead of nix.flake.nixandflake.lock.Verification
Validated on a fresh clone of this branch (no caches, natural mtimes — i.e. true CI conditions) with the pinned toolchain (go 1.26.3):
mise install→ all tools provision.make check→formatted 44 files (0 changed), exit 0, no drift.make test→ok github.com/coder/acp-go-sdk, all examples build.actionlint+zizmor→ clean on the rewritten workflow.🤖 Generated with Claude Code