Skip to content

fix: add ARIA roles to leaderboard divs for screen reader accessibility (#171) #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
5hivam123 wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −0
Open

fix: add ARIA roles to leaderboard divs for screen reader accessibility (#171) #184

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f69060
fix: add ARIA roles to leaderboard for screen reader accessibility
5hivam123 Jun 15, 2026
4d52c86
Merge branch 'main' into fix/leaderboard-aria-roles
jagdish-15 Jun 15, 2026
fcfe4ec
style: auto-format code with Prettier (/format)
github-actions[bot] Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions frontend/js/leaderboard/render.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ function renderLeaderboardRow(user, rank) {

const row = document.createElement("div");
row.className = "leaderboard-row";
row.setAttribute("role", "row");

// Compare checkbox column
const checkboxCell = document.createElement("div");
Expand All @@ -137,11 +138,13 @@ function renderLeaderboardRow(user, rank) {
const rankDiv = document.createElement("div");
rankDiv.className = "rank";
rankDiv.textContent = rank;
rankDiv.setAttribute("role", "cell");
row.appendChild(rankDiv);

// Name cell — tag is safe DOM element, name is user-controlled (textContent)
const nameDiv = document.createElement("div");
nameDiv.className = "name-cell";
nameDiv.setAttribute("role", "cell");
if (rankTagEl) {
nameDiv.appendChild(rankTagEl);
}
Expand All @@ -160,6 +163,7 @@ function renderLeaderboardRow(user, rank) {
// Username with link and external icon — id is user-controlled (textContent)
const usernameDiv = document.createElement("div");
usernameDiv.className = "username";
usernameDiv.setAttribute("role", "cell");
const link = document.createElement("a");
link.href = `https://leetcode.com/u/${user.id}`;
link.target = "_blank";
Expand All @@ -174,29 +178,34 @@ function renderLeaderboardRow(user, rank) {
const easyDiv = document.createElement("div");
easyDiv.className = "easy";
easyDiv.textContent = user.data.easySolved;
easyDiv.setAttribute("role", "cell");
row.appendChild(easyDiv);

// Medium (numeric — safe)
const mediumDiv = document.createElement("div");
mediumDiv.className = "medium";
mediumDiv.textContent = user.data.mediumSolved;
mediumDiv.setAttribute("role", "cell");
row.appendChild(mediumDiv);

// Hard (numeric — safe)
const hardDiv = document.createElement("div");
hardDiv.className = "hard";
hardDiv.textContent = user.data.hardSolved;
hardDiv.setAttribute("role", "cell");
row.appendChild(hardDiv);

// Total (numeric — safe)
const totalDiv = document.createElement("div");
totalDiv.className = "total";
totalDiv.textContent = user.data.totalSolved;
totalDiv.setAttribute("role", "cell");
row.appendChild(totalDiv);

// Score with tooltip — all content is numeric or hardcoded labels
const scoreDiv = document.createElement("div");
scoreDiv.className = "mobile-score tooltip-score";
scoreDiv.setAttribute("role", "cell");

const scoreSpan = document.createElement("span");
scoreSpan.textContent = user.score;
Expand Down
Loading