fix: improved rank change indicator visibility and added hover details (#153)#177
Merged
jagdish-15 merged 3 commits intoJun 15, 2026
Conversation
Contributor
|
Thank you for submitting a pull request. Please ensure your changes comply with the project's contribution guidelines and that all workflow checks pass successfully. Formatting and Branching
|
Collaborator
|
/format |
Contributor
|
I have successfully run Prettier and pushed the formatting fixes to this PR. Note for Contributors: Because this commit was pushed by a bot, GitHub will not automatically re-run the CI checks. To trigger them to pass, you must either:
|
jagdish-15
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR resolves issue #153 by drastically reducing visual noise on the leaderboard columns and providing highly contextual, responsive hover details for student progress tracking.
Tasks Completed
createRankChangeElementconditional loops insiderender.jsto clear out neutral marker noise.main.css.Detailed Breakdown of Changes
1. JavaScript Logic Updates (
js/leaderboard/render.js)[=]Clutter: Added a defensive check at the top ofcreateRankChangeElementthat returnsnullimmediately ifrankChange === "=". This prevents the creation of empty or neutral DOM blocks across table rows.+or-) and dynamically generates readable strings like:↑3Rank increased by 3 places today↓2Rank dropped by 2 places today[NEW]Newly added to the leaderboard2. CSS Architecture Additions (
frontend/styles/main.css)[data-tooltip]::before) that targets your updatedrank-changespans.var(--bg-raised),var(--green), andvar(--text)) so that popup containers automatically adhere to the project's retro CRT layout system without manual color hardcoding.opacityandpointer-events: none), completely avoiding bulky scroll or mouse listeners inside the JavaScript layer.@media (max-width: 480px)) that switches tooltip projection frombottom: 140%totop: 140%on tight mobile layouts to securely prevent display clipping off the edge of the device screen.Verification Testing