Skip to content

Conversation

@shai-almog
Copy link
Contributor

Summary

  • refactor the converter so the single-directory workflow can be reused programmatically
  • add a --github CLI mode that clones a repository, finds Android skin directories, and converts them all
  • update the README with documentation for the new GitHub workflow and CLI usage examples

Testing

  • javac AvdSkinToCodenameOneSkin.java

Codex Task

@shai-almog shai-almog merged commit 5a3422f into master Nov 14, 2025
1 check passed
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +359 to +362
private record ConversionSummary(List<Path> generatedSkins, List<ConversionFailure> failures) {
}

System.out.println("Codename One skin created at: " + outputFile);
private record ConversionFailure(String relativePath, String message) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Avoid Java 14+ syntax in Java 8 project

The project’s build.xml compiles sources with source="1.8"/target="1.8", but this change introduces Java‑14+ features (text blocks, arrow switch labels, and notably the record declarations ConversionSummary/ConversionFailure). These constructs will not compile when the build runs under Java 8, causing the command‑line tool to fail to build. Replace the records and other newer syntax with Java 8 equivalents or raise the configured source level before merging.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants