Skip to content

Workaround for EDT violation in user code#4727

Merged
shai-almog merged 1 commit intomasterfrom
workaround-for-combobox-edt-violation-4726
Apr 9, 2026
Merged

Workaround for EDT violation in user code#4727
shai-almog merged 1 commit intomasterfrom
workaround-for-combobox-edt-violation-4726

Conversation

@shai-almog
Copy link
Copy Markdown
Collaborator

Fixed #4726

Fixed #4726 4726

Signed-off-by: Shai Almog <67850168+shai-almog@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Generated automatically by the PR CI workflow.

@shai-almog
Copy link
Copy Markdown
Collaborator Author

shai-almog commented Apr 9, 2026

Compared 36 screenshots: 36 matched.

Native Android coverage

  • 📊 Line coverage: 7.95% (4073/51256 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
    • Other counters: instruction 6.26% (20143/321833), branch 2.99% (933/31229), complexity 3.72% (1110/29874), method 6.51% (907/13928), class 10.70% (198/1850)
    • Lowest covered classes
      • kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
      • kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
      • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
      • kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
      • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
      • kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/712 lines covered)
      • kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
      • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
      • kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
      • kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

  • 📊 Line coverage: 7.95% (4073/51256 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
    • Other counters: instruction 6.26% (20143/321833), branch 2.99% (933/31229), complexity 3.72% (1110/29874), method 6.51% (907/13928), class 10.70% (198/1850)
    • Lowest covered classes
      • kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
      • kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
      • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
      • kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
      • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
      • kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/712 lines covered)
      • kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
      • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
      • kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
      • kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

Benchmark Results

Detailed Performance Metrics

Metric Duration
Base64 payload size 8192 bytes
Base64 benchmark iterations 6000
Base64 native encode 1427.000 ms
Base64 CN1 encode 167.000 ms
Base64 encode ratio (CN1/native) 0.117x (88.3% faster)
Base64 native decode 1027.000 ms
Base64 CN1 decode 224.000 ms
Base64 decode ratio (CN1/native) 0.218x (78.2% faster)

@shai-almog shai-almog merged commit bf566c8 into master Apr 9, 2026
16 checks passed
@shai-almog
Copy link
Copy Markdown
Collaborator Author

shai-almog commented Apr 9, 2026

Compared 36 screenshots: 36 matched.
✅ Native iOS screenshot tests passed.

Benchmark Results

  • VM Translation Time: 0 seconds
  • Compilation Time: 130 seconds

Detailed Performance Metrics

Metric Duration
Simulator Boot 1000 ms
Simulator Boot (Run) 1000 ms
App Install 3000 ms
App Launch 5000 ms
Test Execution 154000 ms
Base64 payload size 8192 bytes
Base64 benchmark iterations 6000
Base64 native encode 950.000 ms
Base64 CN1 encode 1824.000 ms
Base64 encode ratio (CN1/native) 1.920x (92.0% slower)
Base64 native decode 684.000 ms
Base64 CN1 decode 1120.000 ms
Base64 decode ratio (CN1/native) 1.637x (63.7% slower)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NPE in the EDT

1 participant