Support multiple top-level class wrappers in Playground BeanShell runner#4715
Closed
liannacasper wants to merge 6 commits intomasterfrom
Closed
Support multiple top-level class wrappers in Playground BeanShell runner#4715liannacasper wants to merge 6 commits intomasterfrom
liannacasper wants to merge 6 commits intomasterfrom
Conversation
Cloudflare Preview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
unwrapSingleTopLevelClassto accumulate and unwrap consecutive top-level class bodies instead of rejecting when more than one top-level class exists.transformFieldDeclarationswhere needed.smokeMultipleClassWrapperScript()toPlaygroundSmokeHarnessand call it frommain()to exercise a two-class script (Helpers+Demo).scripts/cn1playground/README.mdtext to reflect that top-level classes (plural) are unwrapped.Testing
./tools/run-playground-smoke-tests.shwhich failed due to environment constraints (missing Java 8 toolchain and local CN1 build client artifacts), so the script could not complete in this environment.mvn -pl common -am -DskipTests compilewhich reached thecn1playground-commonbuild but failed during the CN1 bootstrap/download step because the environment could not fetchUpdateCodenameOne.jar(Network is unreachable) and a localcn1playground-ZipSupportartifact was missing.Codex Task