Android 11+ Background Location Permission Flow Update #4336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement special handling for `ACCESS_BACKGROUND_LOCATION` on API >= 30 in `AndroidImplementation.java`. - Bypass `ActivityCompat.requestPermissions` and guide users to Settings. - Add localization keys for new dialog strings. - Update developer guide with instructions on new behavior and build hint requirements.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
|
Developer Guide build artifacts are available for download from this workflow run:
Developer Guide quality checks: |
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
Collaborator
|
Compared 30 screenshots: 30 matched. Native Android coverage
✅ Native Android screenshot tests passed. Native Android coverage
|
- Implement special handling for `ACCESS_BACKGROUND_LOCATION` on API >= 30 in `AndroidImplementation.java`. - Bypass `ActivityCompat.requestPermissions` and guide users to Settings. - Add localization keys for new dialog strings. - Update developer guide with instructions on new behavior and build hint requirements.
Clarified the process for requesting background location permissions on Android 11 and higher, including details about Codename One's handling of the flow and customization options.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
AndroidImplementation.javato handle theACCESS_BACKGROUND_LOCATIONpermission separately on Android 11 (API 30) and newer. Instead of the standard permission request, which is often silently ignored or restricted by the OS for background location, the app now presents a dialog explaining the requirement and then directs the user to the app's settings page to manually enable "Allow all the time".The dialog strings are customizable via
Displayproperties:android.permission.ACCESS_BACKGROUND_LOCATION.titleandroid.permission.ACCESS_BACKGROUND_LOCATION.settingsandroid.permission.ACCESS_BACKGROUND_LOCATION.cancelandroid.permission.ACCESS_BACKGROUND_LOCATION.explanation_titleandroid.permission.ACCESS_BACKGROUND_LOCATION.explanation_bodyandroid.permission.ACCESS_BACKGROUND_LOCATION.okUpdated
docs/developer-guide/Miscellaneous-Features.asciidocto document this new behavior and theandroid.requiresBackgroundLocationPermissionForAPI29build hint.PR created automatically by Jules for task 11775562847077425485 started by @shai-almog