Feature/metal 2025 #4327

shannah · 2025-12-21T15:13:37Z

No description provided.

Hello world sort of works with this, but not perfectly. There are still clipping issues, and probably performance issues. Only implements a few of the key executable ops - enough to get hello world working.

github-actions · 2025-12-21T15:20:22Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 2276 total, 0 failed, 0 skipped
📊 Line coverage: 52.87% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.ui.BrowserWindow$BrowserForm – 0.00%
  - com.codename1.processing.TextEvaluator – 3.45%
  - com.codename1.charts.views.PieChart – 4.00%
  - com.codename1.charts.views.PieMapper – 4.88%
  - com.codename1.charts.views.ScatterChart – 5.32%
  - com.codename1.ui.list.GenericListCellRenderer$Monitor – 5.33%
  - com.codename1.ui.Display$EdtException – 5.56%
  - com.codename1.testing.AbstractTest – 6.05%
  - com.codename1.ui.Transform$ImmutableTransform – 6.06%
  - com.codename1.charts.views.DoughnutChart – 6.25%

Static Analysis

❌ SpotBugs: 788 findings (High: 61, Normal: 451, Low: 276) [HTML preview] [Download]
- Top findings
  - High: CodenameOne/src/com/codename1/charts/views/XYChart.java:128 – Call to equals() comparing different types (rule: EC_UNRELATED_TYPES)
  - High: CodenameOne/src/com/codename1/compat/java/util/Objects.java:51 – Redundant nullcheck of value known to be non-null (rule: RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE)
  - High: CodenameOne/src/com/codename1/components/ImageViewer.java:310 – Condition has no effect (rule: UC_USELESS_CONDITION)
  - High: CodenameOne/src/com/codename1/components/ToastBar.java:1021 – Potentially ambiguous invocation of either an inherited or outer method (rule: IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD)
  - High: CodenameOne/src/com/codename1/facebook/FaceBookAccess.java:191 – Reliance on default encoding (rule: DM_DEFAULT_ENCODING)
  - …and 783 more
❌ PMD: 2712 findings (P2: 1, P3: 633, P4: 2078) [HTML preview] [Download]
- Top findings
  - P2: CodenameOne/src/com/codename1/ui/Display.java:1022 – Avoid using a branching statement as the last in a loop. (rule: AvoidBranchingStatementAsLastInLoop)
  - P3: CodenameOne/src/com/codename1/charts/views/LineChart.java:208 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - P3: CodenameOne/src/com/codename1/facebook/FacebookRESTService.java:76 – Avoid unused constructor parameters such as 'token'. (rule: UnusedFormalParameter)
  - P3: CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java:8445 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - P3: CodenameOne/src/com/codename1/impl/FullScreenAdService.java:103 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - …and 2707 more
❌ Checkstyle: 219901 findings (Warning: 219901) [HTML preview] [Download]
- Top findings
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:30:1 – Extra separation in import group before 'java.io.IOException' (rule: CustomImportOrderCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:32 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:36 – Line is longer than 100 characters (found 143). (rule: LineLengthCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:39:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:40:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - …and 219896 more

Generated automatically by the PR CI workflow.

shai-almog · 2025-12-21T15:28:13Z

Compared 30 screenshots: 30 matched.

Native Android coverage

📊 Line coverage: 24.62% (2626/10667 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 24.16% (12160/50336), branch 15.13% (702/4640), complexity 17.30% (730/4220), method 32.40% (588/1815), class 33.99% (103/303)
- Lowest covered classes
  - com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
  - com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidDB – 0.00% (0/57 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

📊 Line coverage: 24.62% (2626/10667 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 24.16% (12160/50336), branch 15.13% (702/4640), complexity 17.30% (730/4220), method 32.40% (588/1815), class 33.99% (103/303)
- Lowest covered classes
  - com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
  - com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidDB – 0.00% (0/57 lines covered)

shai-almog · 2025-12-21T15:37:38Z

iOS screenshot updates

Compared 30 screenshots: 23 matched, 6 updated, 1 missing reference.

BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.
graphics-draw-arc — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-arc.png in workflow artifacts.
graphics-draw-gradient — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.
graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.
graphics-draw-string — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.
graphics-draw-string-decorated — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.
kotlin — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as kotlin.png in workflow artifacts.

Benchmark Results

VM Translation Time: 298 seconds
Compilation Time: 57 seconds

Detailed Performance Metrics

Metric	Duration
Build Time Statistics
Setup & Unzip	24486 ms
Extract Extensions	14 ms
Google Services Setup	2 ms
Scan Classes	472 ms
Extract Libs	939 ms
Inject Build Hints	30 ms
Generate Unit Tests	2 ms
Generate Stubs	862 ms
Compile Stubs	2117 ms
Generate Icons	998 ms
Prepare ParparVM	204 ms
ParparVM Execution	169501 ms
Post-VM Setup	159 ms
CocoaPods	4436 ms
Finalize	37 ms
Total Time	204260 msMaven Overhead : 94000 ms
CocoaPods Install (Script)	1000 ms
Simulator Boot (Run)	44000 ms
App Install	23000 ms
App Launch	8000 ms
Test Execution	137000 ms

shannah added 5 commits December 21, 2025 07:10

Initial metal foundations

9548141

Initial work on Metal support.

906e952

Hello world sort of works with this, but not perfectly. There are still clipping issues, and probably performance issues. Only implements a few of the key executable ops - enough to get hello world working.

More deltas to get hello world working on metal

f596a1e

Fixed some clipping issues

61b5d93

fix: Memory leaks in GLUIImage and DrawString when using METAL

bdcf380

shannah marked this pull request as draft December 21, 2025 15:13

chore: Change hellocodenameone project to use metal renderer for testing

8183c73

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature/metal 2025 #4327

Feature/metal 2025 #4327

Uh oh!

shannah commented Dec 21, 2025

Uh oh!

github-actions bot commented Dec 21, 2025 •

edited

Loading

Uh oh!

shai-almog commented Dec 21, 2025 •

edited

Loading

Uh oh!

shai-almog commented Dec 21, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Feature/metal 2025 #4327

Are you sure you want to change the base?

Feature/metal 2025 #4327

Uh oh!

Conversation

shannah commented Dec 21, 2025

Uh oh!

github-actions bot commented Dec 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Uh oh!

shai-almog commented Dec 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Native Android coverage

Native Android coverage

Uh oh!

shai-almog commented Dec 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS screenshot updates

Benchmark Results

Detailed Performance Metrics

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Dec 21, 2025 •

edited

Loading

shai-almog commented Dec 21, 2025 •

edited

Loading

shai-almog commented Dec 21, 2025 •

edited

Loading