Simplify iOS UI test screenshot pipeline #4086
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| SIM_DEVICE_NAME="${IOS_SIM_DEVICE_NAME:-iPhone 16}" | ||
| SIM_UDID="" | ||
| ensure_booted_device "$SIM_DEVICE_NAME" || true | ||
| if [ -z "$SIM_UDID" ]; then | ||
| ri_log "Falling back to 'booted' simulator for destination" | ||
| SIM_DESTINATION="platform=iOS Simulator,name=$SIM_DEVICE_NAME" | ||
| else |
There was a problem hiding this comment.
The new script always targets IOS_SIM_DEVICE_NAME (default iPhone 16) and, on failure, simply uses platform=iOS Simulator,name=$SIM_DEVICE_NAME without trying to discover another available simulator. Earlier versions parsed xcodebuild -showdestinations/simctl list and auto‑selected a usable device when the default wasn’t present. In environments where the requested device isn’t installed (e.g., older Xcode images or custom CI with a different simulator set), ensure_booted_device leaves SIM_UDID empty, and the subsequent xcodebuild invocation will exit with “Unable to find a destination matching the provided destination specifier”, causing all UI tests to fail even though other simulators are available. Please retain an automatic fallback to any available simulator when the preferred device cannot be found.
Useful? React with 👍 / 👎.
|
Developer Guide build artifacts are available for download from this workflow run:
Developer Guide quality checks: |
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68ff083a182483319eaf75127d555b79