Fix concatenating sentence parts separated with newlines#873
Open
dhgelling wants to merge 1 commit intocodelucas:masterfrom
Open
Fix concatenating sentence parts separated with newlines#873dhgelling wants to merge 1 commit intocodelucas:masterfrom
dhgelling wants to merge 1 commit intocodelucas:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The text content of newspapers seems to be returned as paragraphs separated by two newlines. When doing nlp on this, the tokenizer sometimes thinks a sentence spans across two paragraphs, returning a sentence looking like
'first sentence\n\nsecond sentence', which means this part of the code would concatenate the words sentence and second, returning'first sentencesecond sentence'. This change is meant to fix that, by replacing any run of multiple spaces or newlines by one space.Another solution would be to first split on double newlines and processing the content of that separately before concatenating again, but this seemed like it would change the least