Skip to content

Conversation

@datamweb
Copy link
Collaborator

@datamweb datamweb commented Dec 5, 2025

Description
This update makes the Magic-Login system configurable without breaking backward compatibility. Now developers can choose between:

  1. A activation link(clickable)
  2. A verification code — in 6-numeric, 6-alpha, 6-alnum or 6-oneof format.

This flexibility lets you adapt authentication to your app’s needs, compliance rules, or user-experience preferences.

For the code-based flow, a new dedicated view is introduced to keep things clean and avoid conflicts with existing or customized views, ensuring backwards compatibility.

close : #1293
see : #1261
Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@datamweb datamweb added enhancement New feature or request new feature PRs for new features labels Dec 5, 2025
@datamweb datamweb force-pushed the feat-magic-login-method branch from d64dc48 to b92af36 Compare December 6, 2025 12:29
@datamweb datamweb force-pushed the feat-magic-login-method branch from 750c12c to f2e3ec8 Compare December 6, 2025 13:43
@datamweb datamweb force-pushed the feat-magic-login-method branch from 21e6d75 to 84ab8d9 Compare December 6, 2025 14:03
Copy link

@sanchawebo sanchawebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing: You have multiple calls to resolveMode() in the loginAction() method, which generates a new token everytime. This could lead to confusion about its usage in the future.
Otherwise looks good to me and would fix my issue #1261

@datamweb
Copy link
Collaborator Author

datamweb commented Dec 8, 2025

@sanchawebo Thank you for your helpful review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request new feature PRs for new features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dev: Add bot detection for magic links

2 participants