test: set fixed time for time-dependent tests#1281
Merged
michalsn merged 3 commits intocodeigniter4:developfrom Jul 16, 2025
Merged
test: set fixed time for time-dependent tests#1281michalsn merged 3 commits intocodeigniter4:developfrom
michalsn merged 3 commits intocodeigniter4:developfrom
Conversation
datamweb
approved these changes
Jul 16, 2025
Collaborator
datamweb
left a comment
datamweb
left a comment
There was a problem hiding this comment.
In general, I don't like using humanize() in such tests. Look good to me.
Thanks!
Member
Author
|
Thank you @datamweb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes two tests that were previously dependent on the current system time by setting a fixed time at the beginning of each test. This ensures consistent and deterministic test results.
Fixes #1280
Checklist: