chore: fix code to comply with latest PHPStan, Rector and CS#1268
Merged
michalsn merged 7 commits intocodeigniter4:developfrom Jul 5, 2025
Merged
chore: fix code to comply with latest PHPStan, Rector and CS#1268michalsn merged 7 commits intocodeigniter4:developfrom
michalsn merged 7 commits intocodeigniter4:developfrom
Conversation
datamweb
approved these changes
Jul 4, 2025
Member
Author
|
Turns out the CS issue was related to using the FQCN, not the comment itself. Fixed. |
datamweb
approved these changes
Jul 5, 2025
Collaborator
datamweb
left a comment
datamweb
left a comment
There was a problem hiding this comment.
Classic time-waster disguised as a simple comment. Glad you hunted it down. Thanks!
paulbalandan
approved these changes
Jul 5, 2025
Member
Author
|
Thank you @datamweb and @paulbalandan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes all failing checks.
CSFor some reason, this line with a comment was causing a failure.
If anyone knows how to fix this, please share your thoughts or open a PR.
PHPStan
The main issue came from this PHPStan release: v2.1.13
Since we intentionally use
@internalin some places, I decided to ignore these errors for now. All other issues are listed in this job run.Rector
I followed the suggested changes from Rector. If a rule was removed, Rector required it.
There were no side effects, so everything looks good.
Checklist: