Skip to content

docs: require activator in custom actions class name for register#1251

Merged
datamweb merged 2 commits intocodeigniter4:developfrom
datamweb:docs-require-Activator-in-class-name
Feb 15, 2025
Merged

docs: require activator in custom actions class name for register#1251
datamweb merged 2 commits intocodeigniter4:developfrom
datamweb:docs-require-Activator-in-class-name

Conversation

@datamweb
Copy link
Collaborator

@datamweb datamweb commented Feb 14, 2025

Description
fix: #1249

In this implementation, since we cannot determine whether the user provides just the class name or the fully qualified namespace of the class, we are unable to directly verify the ActionInterface implementation. Therefore, we rely on the class name suffix ('Activator') as a consistent identifier for validation.

see:

return str_contains(setting('Auth.actions')['register'] ?? '', 'Activator');

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@datamweb datamweb added the documentation Improvements or additions to documentation label Feb 14, 2025
@datamweb datamweb merged commit e782eb0 into codeigniter4:develop Feb 15, 2025
37 checks passed
@datamweb
Copy link
Collaborator Author

Thanks!

@datamweb datamweb deleted the docs-require-Activator-in-class-name branch February 15, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: User isActivated() always returns true, even when custom activator is configured

3 participants