Merged
Conversation
michalsn
requested review from
datamweb,
kenjis,
paulbalandan and
samsonasik
samsonasik
approved these changes
Feb 10, 2025
datamweb
approved these changes
Feb 10, 2025
Collaborator
|
I see this change as fair and reasonable. |
paulbalandan
approved these changes
Feb 11, 2025
Member
Author
|
Thanks for the review guys! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR ignores two Rector rules which were added in the latest versions.
I believe that the application of these rules will negatively affect the readability of our tests.
Here are the proposed changes in the codebase by Rector: https://github.com/codeigniter4/shield/actions/runs/13240274064/job/36953902890
I'm not super convinced about it - this was just my first impression.
Checklist: