Merged
Conversation
neznaika0
commented
Dec 11, 2025
neznaika0
commented
Dec 11, 2025
michalsn
reviewed
Dec 12, 2025
Member
michalsn
left a comment
There was a problem hiding this comment.
-
If you're referring to manually removing old session data, then yes. If you're referring to the PHP session GC mechanism, then no.
-
That is clearly a mistake. It should use the same property names as the fallback, but loaded from the config file.
-
I don't think we will make that change now. Maybe in the new docs, if we eventually migrate. Users on older CI versions can always download the appropriate version of the user guide from the userguide repository.
649aec2 to
5214258
Compare
|
👋 Hi, @neznaika0! |
5214258 to
cfba4fd
Compare
f6f736d to
fac4963
Compare
paulbalandan
approved these changes
Dec 31, 2025
Member
|
Thank you @neznaika0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sessionhave been removed.FileHandler, what should I add to the guide about cleaning up old sessions? While I was reviewing the commit, I remembered about GC. Can I add information about him?I have removed the
stop()method - it is not needed for the v4.7 documentation, but people reading for v4.3 should know about it. For good measure, we need to switch to a different version system for the guide. At least clear the notes for major versions 4.4, 4.5, 4.6...Checklist: