fix: Catch ValueError from hex2bin() in Security::derandomize() on PHP 8#10320
Open
gr8man wants to merge 2 commits into
Open
fix: Catch ValueError from hex2bin() in Security::derandomize() on PHP 8#10320gr8man wants to merge 2 commits into
gr8man wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where providing a malformed CSRF token crashes the application on newer PHP versions (particularly PHP 8.4+) instead of gracefully rejecting it.
Inside
Security::derandomize(), thehex2bin()function is used to decode the randomized token. If the provided hex string is invalid (e.g., contains non-hexadecimal characters or has an odd length), older PHP versions emitted anE_WARNINGwhich the framework's error handler converted to anErrorException.However, in newer PHP 8 releases,
hex2bin()natively throws aValueErrorfor invalid input strings. Because thetry/catchblock was only capturingErrorException, theValueErrorescaped unhandled, resulting in a fatal crash.Changes:
try/catchblock inSecurity::derandomize()to catchValueErroralongsideErrorException.testDerandomizeThrowsInvalidArgumentExceptionOnInvalidHex()to the test suite, which intentionally passes a strictly invalid hexadecimal string to verify that theInvalidArgumentExceptionis correctly re-thrown without a fatal error.Checklist: