fix: unify casing in BaseService::injectMock#10316
Open
ThomasMeschke wants to merge 1 commit into
Open
Conversation
5 tasks
Member
|
Thank you. Could you add a changelog entry here: https://github.com/codeigniter4/CodeIgniter4/blob/develop/user_guide_src/source/changelogs/v4.7.4.rst |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The BaseService::injectMock method only applied the strtolower function to the name in regard to the mock-list, but not to the instance-list:
Every other method in the BaseService applies strtolower to the name argument before doing anything else, e.g. resetSingle:
... or getSharedInstance:
This results in two different instance entries when injectMock gets called with "fooBar" and with "foobar" respectively, but only one of them (namely "foobar") is ever to be resolved or reset again.
When not using all-lowercase while calling injectMock, any existing instance that is meant to be replaced is therefore not being replaced.
Checklist: