fix: SQLite3 config type handling for .env overrides#10037
Open
michalsn wants to merge 4 commits intocodeigniter4:developfrom
Open
fix: SQLite3 config type handling for .env overrides#10037michalsn wants to merge 4 commits intocodeigniter4:developfrom
.env overrides#10037michalsn wants to merge 4 commits intocodeigniter4:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where database config values coming from
.envcould remain strings and then be assigned to typed SQLite3 connection properties with the wrong type. That could trigger aTypeErrorforsynchronousor causebusyTimeoutto be ignored.The fix normalizes string config values when they are assigned to typed connection properties, and also types
SQLite3\Connection::$busyTimeoutas?intso it behaves consistently. This is done inBaseConnection, where the real destination type is known, rather than trying to guess types fornullvalues in config arrays.Fixes #10021
Checklist: