Conversation
|
Hello @janitha09 - I apologize for letting this PR fall between the cracks. We would be happy to merge it into the master branch. Can you please merge/rebase it, and we will have a look again? |
janitha09
force-pushed
the
master
branch
2 times, most recently
from
384d395 to
ad99aea
Compare
|
@noam-codefresh merge conflicts and API changes have been resolved for |
| { | ||
| "go.testFlags": ["-v"] | ||
| } No newline at end of file |
There was a problem hiding this comment.
please do not include this file in the pr
I see the repo doesn't have a .gitignore file - maybe even include one that ignores visual studio code and golang artifacts? (just a suggestion)
|
|
||
| func TestProject(t *testing.T) { | ||
|
|
||
| cf := New(&clientOptions) |
There was a problem hiding this comment.
maybe you can use the codefresh/mock/codefresh struct to make this test better?
you will also need to regenerate the mock itself to include your Projects() func. You will need mockery 1.1.1 installed, and run go generate ./... for it.
let me know if you need any help with it.
There was a problem hiding this comment.
@noam-codefresh is there an example that shows the coddfresh mock structs use.
For an API client that should have been code generated, this abstraction is proving to be rather tedious, and hard to follow, it most certainly confuses the compiler
2 participants
This change implements project list endpoint