feat: direct nav stack creation and auto-derived navigation structure#6
Open
trmquang93 wants to merge 1 commit intomainfrom
Open
feat: direct nav stack creation and auto-derived navigation structure#6trmquang93 wants to merge 1 commit intomainfrom
trmquang93 wants to merge 1 commit intomainfrom
Conversation
…tion UI - Replace manual navigationStructure state with useMemo derived from screenGroups: 0 nav-stack groups → null, 1 → single-stack, 2+ → tab-bar - Remove navigation config dropdown/checkboxes from ScreensPanel - Add "Stack" button to BatchSelectionBar to group selected screens into a nav stack - Add "Create new nav stack..." to screen right-click context menu - Remove setNavigationStructure from useImportExport (re-derived from imported screenGroups) - Extend ScreenGroup, Sidebar, analyzeNavGraph, generateInstructionFiles, validateInstructions with nav-stack awareness and stack entry screen configuration
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
navigationStructurefromscreenGroupsviauseMemo— 0 nav-stack groups →null, 1 →single-stack, 2+ →tab-bar. Eliminates manual state that could drift out of sync with the canvas.stackEntryScreenId.setNavigationStructureremoved fromuseImportExport; on import the value is re-derived from the importedscreenGroups.Test plan
navigationStructure.typebecomessingle-stacktab-barnavigationStructureupdates automaticallyscreenGroupsnavigation.mdandbuild-guide.mdnpm test— all 229 tests pass