Skip to content

⚡️ Speed up method OneNoteDataSource.me_onenote_delete_section_groups by 11% #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method OneNoteDataSource.me_onenote_delete_section_groups by 11% #1165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions backend/python/app/sources/external/microsoft/one_note/one_note.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@


import json
import logging
from dataclasses import asdict
Expand Down Expand Up @@ -20748,8 +20746,10 @@ async def me_onenote_delete_section_groups(
"""
# Build query parameters including OData for OneNote
try:
# Use typed query parameters
query_params = RequestConfiguration()
# Compose query and headers more efficiently
config = RequestConfiguration()
query_params = config.query_parameters

# Set query parameters using typed object properties
if select:
query_params.select = select if isinstance(select, list) else [select]
Expand All @@ -20766,20 +20766,20 @@ async def me_onenote_delete_section_groups(
if skip is not None:
query_params.skip = skip

# Create proper typed request configuration
config = RequestConfiguration()
config.query_parameters = query_params

if headers:
config.headers = headers
config.headers = headers.copy()
else:
config.headers = {}

# Add consistency level for search operations in OneNote

# Add consistency level for search operations in OneNote
if search:
if not config.headers:
config.headers = {}
config.headers['ConsistencyLevel'] = 'eventual'

response = await self.client.me.onenote.section_groups.by_section_group_id(sectionGroup_id).delete(request_configuration=config)
response = await self.client.me.onenote.section_groups.by_section_group_id(
sectionGroup_id
).delete(request_configuration=config)
return self._handle_onenote_response(response)
except Exception as e:
return OneNoteResponse(
Expand Down