Add PWR074: Prefer use <module> over include <source file>#30
Draft
Add PWR074: Prefer use <module> over include <source file>#30
use <module> over include <source file>#30Conversation
use <module> over include <source file>
|
Hi @alvrogd, in general this is a nice idea, but sometimes function mat_op(a) result(y)
real :: a(..)
real :: y
select rank(a)
rank(0)
include 'long_expression_that_is_rank_agnostic.f90'
rank(1)
include 'long_expression_that_is_rank_agnostic.f90'
rank(2)
include 'long_expression_that_is_rank_agnostic.f90'
end select
end functionA similar, more concrete, example is provided at this implementation of a generic list. In this case, the code depends on a compiler directive. Therefore, it cannot be compiled and Just to be clear, there are plenty of cases where this PR makes sense (mostly old F77 code), but distinguishing the cases where |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just the entry and example codes. The benchmark will be added soon.