Skip to content

Generalize a castling rights parser and add some FRC positions in bench.#891

Merged
codedeliveryservice merged 11 commits intocodedeliveryservice:mainfrom
protonspring:ps_castling101
Apr 14, 2026
Merged

Generalize a castling rights parser and add some FRC positions in bench.#891
codedeliveryservice merged 11 commits intocodedeliveryservice:mainfrom
protonspring:ps_castling101

Conversation

@protonspring
Copy link
Copy Markdown
Contributor

Partial STC just to make sure nothing bad happened.

https://recklesschess.space/test/13393/

@codedeliveryservice
Copy link
Copy Markdown
Owner

I believe in case of X-FEN notation, for example nqrnbkrb/pppppppp/8/8/8/8/PPPPPPPP/NQRNBKRB w KQkq - 0 1, your patch recognizes KQkq as standard rook files instead of searching for the rook on the appropriate side.
P.S. Bitboard::msb seems to be unused.

@protonspring
Copy link
Copy Markdown
Contributor Author

ach so. the only consistent solution is to find the rook from either side of the king? I had msb for that reason.

Thanks. i will fix that in a few hours!

@protonspring
Copy link
Copy Markdown
Contributor Author

Should I remove msb?

@protonspring
Copy link
Copy Markdown
Contributor Author

@codedeliveryservice codedeliveryservice merged commit 56ce430 into codedeliveryservice:main Apr 14, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants