-
Notifications
You must be signed in to change notification settings - Fork 14
Grep/Highlighting #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grep/Highlighting #178
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
LLM Doc Lint56 tests 53 ✅ 0s ⏱️ For more details on these failures, see this check. Results for commit f3af72b. ♻️ This comment has been updated with latest results. |
|
The line printing stage has been removed, and has been incorporated into this extension: #179 |
LLM Doc Lint70 tests 65 ✅ 0s ⏱️ For more details on these failures, see this check. Results for commit bdfe1fb. ♻️ This comment has been updated with latest results. |
LLM Doc Lint70 tests 66 ✅ 0s ⏱️ For more details on these failures, see this check. Results for commit ec8cd19. ♻️ This comment has been updated with latest results. |
LLM Doc Lint70 tests 66 ✅ 0s ⏱️ For more details on these failures, see this check. Results for commit e9f4865. ♻️ This comment has been updated with latest results. |
| @@ -0,0 +1,90 @@ | |||
| In this stage, you'll add support for highlighting the matched text in your grep implementation. | |||
|
|
|||
| ### Highlighting the matched text | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we have the prerequisites, let's change the ordering here:
- Highlighting a single match
- Highlighting multiple matches
- Disabling highlighting
- Auto highlighting behaviour (not sure about this name, could be improved)
- Default highlighting behaviour (not sure about this name, could be improved)
LLM Doc Lint70 tests 66 ✅ 0s ⏱️ For more details on these failures, see this check. Results for commit b6278c6. ♻️ This comment has been updated with latest results. |
LLM Doc Lint75 tests 0 ✅ 0s ⏱️ For more details on these failures, see this check. Results for commit 29b00ba. ♻️ This comment has been updated with latest results. |
|
Re-requesting since grep's default behavior was later found to be Changes:
|
LLM Doc Lint75 tests 74 ✅ 0s ⏱️ For more details on these failures, see this check. Results for commit ce8f2f8. ♻️ This comment has been updated with latest results. |
LLM Doc Lint75 tests 73 ✅ 0s ⏱️ For more details on these failures, see this check. Results for commit 2c78b53. ♻️ This comment has been updated with latest results. |
LLM Doc Lint75 tests 75 ✅ 0s ⏱️ Results for commit 22b64bc. ♻️ This comment has been updated with latest results. |
|
LLM Doc Lint75 tests 75 ✅ 0 ❌ 5 suites Results for commit This comment updates automatically on new commits. |
Note
Adds a new grep “highlighting” extension with 5 stages (single, multiple, multi-line, disable, auto) and updates course config to include them.
course-definition.yml)extensions.highlightingwith description and links.bm2(single match),eq0(multiple matches),wg2(multi-line),jk4(--color=never),na5(--color=auto).stage_descriptions/highlighting-01-bm2.md: explain ANSI sequences; tests for--color=alwayssingle match.stage_descriptions/highlighting-02-eq0.md: highlight multiple matches in a line; tests.stage_descriptions/highlighting-03-wg2.md: highlight matches across multiple lines; tests.stage_descriptions/highlighting-04-jk4.md: disable highlighting with--color=never; tests.stage_descriptions/highlighting-05-na5.md: auto highlighting based on TTY (--color=auto); tests and notes.Written by Cursor Bugbot for commit 1a48ecc. This will update automatically on new commits. Configure here.