Skip to content

Conversation

@UdeshyaDhungana
Copy link
Contributor

@UdeshyaDhungana UdeshyaDhungana commented Nov 11, 2025

Note

Adds a new grep “highlighting” extension with 5 stages (single, multiple, multi-line, disable, auto) and updates course config to include them.

  • Course config (course-definition.yml)
    • Adds extensions.highlighting with description and links.
    • Adds 5 new highlighting stages: bm2 (single match), eq0 (multiple matches), wg2 (multi-line), jk4 (--color=never), na5 (--color=auto).
  • Stage descriptions
    • Adds stage_descriptions/highlighting-01-bm2.md: explain ANSI sequences; tests for --color=always single match.
    • Adds stage_descriptions/highlighting-02-eq0.md: highlight multiple matches in a line; tests.
    • Adds stage_descriptions/highlighting-03-wg2.md: highlight matches across multiple lines; tests.
    • Adds stage_descriptions/highlighting-04-jk4.md: disable highlighting with --color=never; tests.
    • Adds stage_descriptions/highlighting-05-na5.md: auto highlighting based on TTY (--color=auto); tests and notes.

Written by Cursor Bugbot for commit 1a48ecc. This will update automatically on new commits. Configure here.

@github-actions

This comment was marked as resolved.

@github-actions

This comment was marked as resolved.

@github-actions

This comment was marked as resolved.

@github-actions

This comment was marked as resolved.

@github-actions

This comment was marked as resolved.

@github-actions

This comment was marked as resolved.

@github-actions

This comment was marked as resolved.

@github-actions
Copy link

github-actions bot commented Nov 12, 2025

LLM Doc Lint

56 tests   53 ✅  0s ⏱️
 4 suites   0 💤
 1 files     3 ❌

For more details on these failures, see this check.

Results for commit f3af72b.

♻️ This comment has been updated with latest results.

@UdeshyaDhungana
Copy link
Contributor Author

The line printing stage has been removed, and has been incorporated into this extension: #179

@github-actions
Copy link

github-actions bot commented Nov 14, 2025

LLM Doc Lint

70 tests   65 ✅  0s ⏱️
 5 suites   0 💤
 1 files     5 ❌

For more details on these failures, see this check.

Results for commit bdfe1fb.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 14, 2025

LLM Doc Lint

70 tests   66 ✅  0s ⏱️
 5 suites   0 💤
 1 files     4 ❌

For more details on these failures, see this check.

Results for commit ec8cd19.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 14, 2025

LLM Doc Lint

70 tests   66 ✅  0s ⏱️
 5 suites   0 💤
 1 files     4 ❌

For more details on these failures, see this check.

Results for commit e9f4865.

♻️ This comment has been updated with latest results.

@@ -0,0 +1,90 @@
In this stage, you'll add support for highlighting the matched text in your grep implementation.

### Highlighting the matched text
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we have the prerequisites, let's change the ordering here:

  • Highlighting a single match
  • Highlighting multiple matches
  • Disabling highlighting
  • Auto highlighting behaviour (not sure about this name, could be improved)
  • Default highlighting behaviour (not sure about this name, could be improved)

@github-actions
Copy link

github-actions bot commented Nov 17, 2025

LLM Doc Lint

70 tests   66 ✅  0s ⏱️
 5 suites   0 💤
 1 files     4 ❌

For more details on these failures, see this check.

Results for commit b6278c6.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 25, 2025

LLM Doc Lint

75 tests    0 ✅  0s ⏱️
 5 suites   0 💤
 1 files    75 ❌

For more details on these failures, see this check.

Results for commit 29b00ba.

♻️ This comment has been updated with latest results.

@UdeshyaDhungana
Copy link
Contributor Author

Re-requesting since grep's default behavior was later found to be --never instead of --auto

Changes:

  • Removed the last stage of this extension (default behavior is already implemented by the users)

@github-actions
Copy link

github-actions bot commented Dec 10, 2025

LLM Doc Lint

75 tests   74 ✅  0s ⏱️
 5 suites   0 💤
 1 files     1 ❌

For more details on these failures, see this check.

Results for commit ce8f2f8.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 10, 2025

LLM Doc Lint

75 tests   73 ✅  0s ⏱️
 5 suites   0 💤
 1 files     2 ❌

For more details on these failures, see this check.

Results for commit 2c78b53.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 10, 2025

LLM Doc Lint

75 tests   75 ✅  0s ⏱️
 5 suites   0 💤
 1 files     0 ❌

Results for commit 22b64bc.

♻️ This comment has been updated with latest results.

@UdeshyaDhungana
Copy link
Contributor Author

UdeshyaDhungana commented Dec 10, 2025

  • Added one stage where matches are present in multiple lines (wg2).

@UdeshyaDhungana UdeshyaDhungana merged commit 175411c into main Dec 15, 2025
23 checks passed
@UdeshyaDhungana UdeshyaDhungana deleted the highlighting branch December 15, 2025 10:19
@github-actions
Copy link

LLM Doc Lint

75 tests   75 ✅  0 ❌

5 suites

Results for commit f9762c6.

This comment updates automatically on new commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants