feat: Remove minification of packages#248
Merged
nicholas-codecov merged 6 commits intomainfrom Feb 10, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files
☔ View full report in Codecov by Sentry. |
Bundle ReportChanges will increase total bundle size by 199.38kB (3.1%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @codecov/webpack-plugin-esmAssets Changed:
view changes for bundle: @codecov/solidstart-plugin-cjsAssets Changed:
view changes for bundle: @codecov/astro-plugin-cjsAssets Changed:
view changes for bundle: @codecov/example-sveltekit-app-client-esmAssets Changed:
view changes for bundle: @codecov/nextjs-webpack-plugin-cjsAssets Changed:
view changes for bundle: @codecov/vite-plugin-cjsAssets Changed:
view changes for bundle: @codecov/bundler-plugin-core-cjsAssets Changed:
view changes for bundle: @codecov/rollup-plugin-cjsAssets Changed:
view changes for bundle: @codecov/example-next-app-client-array-pushAssets Changed:
view changes for bundle: @codecov/nextjs-webpack-plugin-esmAssets Changed:
view changes for bundle: @codecov/bundle-analyzer-cjsAssets Changed:
view changes for bundle: @codecov/astro-plugin-esmAssets Changed:
view changes for bundle: @codecov/nuxt-plugin-esmAssets Changed:
view changes for bundle: @codecov/webpack-plugin-cjsAssets Changed:
view changes for bundle: @codecov/nuxt-plugin-cjsAssets Changed:
view changes for bundle: @codecov/bundle-analyzer-esmAssets Changed:
view changes for bundle: @codecov/solidstart-plugin-esmAssets Changed:
view changes for bundle: @codecov/example-sveltekit-app-server-esmAssets Changed:
view changes for bundle: @codecov/example-next-15-app-client-array-pushAssets Changed:
view changes for bundle: @codecov/bundler-plugin-core-esmAssets Changed:
view changes for bundle: @codecov/remix-vite-plugin-esmAssets Changed:
view changes for bundle: @codecov/remix-vite-plugin-cjsAssets Changed:
view changes for bundle: @codecov/sveltekit-plugin-cjsAssets Changed:
|
Bundle ReportChanges will increase total bundle size by 201.35kB (3.21%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @codecov/example-sveltekit-app-server-esmAssets Changed:
view changes for bundle: @codecov/sveltekit-plugin-cjsAssets Changed:
view changes for bundle: @codecov/remix-vite-plugin-esmAssets Changed:
view changes for bundle: @codecov/bundler-plugin-core-cjsAssets Changed:
view changes for bundle: @codecov/bundle-analyzer-cjsAssets Changed:
view changes for bundle: @codecov/nextjs-webpack-plugin-cjsAssets Changed:
view changes for bundle: @codecov/webpack-plugin-esmAssets Changed:
view changes for bundle: @codecov/remix-vite-plugin-cjsAssets Changed:
view changes for bundle: @codecov/solidstart-plugin-cjsAssets Changed:
view changes for bundle: @codecov/bundle-analyzer-esmAssets Changed:
view changes for bundle: @codecov/vite-plugin-cjsAssets Changed:
view changes for bundle: @codecov/rollup-plugin-esmAssets Changed:
view changes for bundle: @codecov/rollup-plugin-cjsAssets Changed:
view changes for bundle: @codecov/astro-plugin-esmAssets Changed:
view changes for bundle: @codecov/bundler-plugin-core-esmAssets Changed:
view changes for bundle: @codecov/astro-plugin-cjsAssets Changed:
view changes for bundle: @codecov/example-next-15-app-client-array-pushAssets Changed:
view changes for bundle: @codecov/example-next-app-client-array-pushAssets Changed:
view changes for bundle: @codecov/webpack-plugin-cjsAssets Changed:
view changes for bundle: @codecov/solidstart-plugin-esmAssets Changed:
view changes for bundle: @codecov/nuxt-plugin-cjsAssets Changed:
view changes for bundle: @codecov/example-sveltekit-app-client-esmAssets Changed:
|
ajay-sentry
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes one build setting for all of the plugins: minification. We're removing minification because as these are dev deps, and are fairly small there's really no reason to minify the packages and make things harder to read/debug if any errors are raised.
Note, reverted changes for sourcemaps, as we're still bundling into a single file, where the sourcemap will point us to the file where the code lives.
Notable Changes