Skip to content

Fix: JSONResponse helper to preserve original onResponse behavior (Fixes #5042) #5106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kobenguyent merged 2 commits into from
Aug 26, 2025
Merged

Fix: JSONResponse helper to preserve original onResponse behavior (Fixes #5042) #5106

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa987ae
Fix: JSONResponse helper to preserve original onResponse behavior (Fi…
Aug 24, 2025
b37b187
Add unit tests for REST onResponse hook functionality:Fixes #5042
Aug 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/helper/JSONResponse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,11 @@ class JSONResponse extends Helper {
if (!this.helpers[this.options.requestHelper]) {
throw new Error(`Error setting JSONResponse, helper ${this.options.requestHelper} is not enabled in config, helpers: ${Object.keys(this.helpers)}`)
}
// connect to REST helper
const origOnResponse = this.helpers[this.options.requestHelper].config.onResponse;
this.helpers[this.options.requestHelper].config.onResponse = response => {
this.response = response
}
this.response = response;
if (typeof origOnResponse === 'function') origOnResponse(response);
};
}

_before() {
Expand Down