fix: apply configured monitor timeout to StatusUpdater (#5147)#5237
Open
Harshit-0413 wants to merge 1 commit intocodecentric:masterfrom
Open
fix: apply configured monitor timeout to StatusUpdater (#5147)#5237Harshit-0413 wants to merge 1 commit intocodecentric:masterfrom
Harshit-0413 wants to merge 1 commit intocodecentric:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The configured monitor timeout (
spring.boot.admin.monitor.default-timeoutand per-service
spring.boot.admin.monitor.timeout) was not being appliedto
StatusUpdater. It always used the default WebClient timeout instead ofthe user-configured value, making the timeout configuration ineffective for
status checks.
Fix
Applied the configured timeout from
AdminServerProperties.MonitorPropertiesin
StatusUpdaterso that user-defined timeouts are respected duringinstance status polling.
Tests
Added tests to verify that the configured timeout is correctly applied
in
StatusUpdater.Note
AdminServerInstanceWebClientConfigurationTest.simpleConfigis failingon
masteras well — this is a pre-existing issue unrelated to this PR.