Merge pull request #769 from code0-tech/fix-invalid-flow-error-throwing

Invalid flows will get validated first before getting passed in the update service

Author: Taucher2003

app/services/namespaces/projects/flows/create_service.rb

@@ -44,6 +44,14 @@ def execute
               return_type: flow_type.return_type
             )
 
+            unless flow.save
+              t.rollback_and_return! ServiceResponse.error(
+                message: 'Flow is invalid',
+                error_code: :invalid_flow,
+                details: flow.errors
+              )
+            end
+
             UpdateService.new(
               current_authentication,
               flow,

spec/requests/graphql/mutation/namespace/projects/flows/create_mutation_spec.rb

@@ -131,6 +131,21 @@
       create(:namespace_member_role, role: namespace_role, member: namespace_member)
     end
 
+    context 'when flow name is taken' do
+      before do
+        create(:flow, name: input[:flow][:name], project: project)
+      end
+
+      it 'returns an error' do
+        mutate!
+
+        expect(graphql_data_at(:namespaces_projects_flows_create, :errors)).to be_present
+        expect(graphql_data_at(:namespaces_projects_flows_create, :flow)).to be_nil
+        expect(graphql_data_at(:namespaces_projects_flows_create, :errors,
+                               :error_code)).to contain_exactly('INVALID_FLOW')
+      end
+    end
+
     it 'creates flow' do
       mutate!