Skip to content

Commit 708acf2

Browse files
authored
Merge pull request #770 from code0-tech/fix-value-normalisation
.presence kills empty arrays as values
2 parents 968478c + 467f053 commit 708acf2

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

app/models/node_parameter.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def to_grpc
3030
private
3131

3232
def only_one_value_present
33-
values = [literal_value.present?, reference_value.present?, function_value.present?]
33+
values = [!literal_value.nil?, reference_value.present?, function_value.present?]
3434
return if values.count(true) == 1
3535

3636
errors.add(:value,

app/services/namespaces/projects/flows/update_service.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ def update_node_parameters(t, current_node, current_node_input, all_nodes)
176176

177177
db_parameters[index].runtime_parameter = runtime_parameter
178178

179-
db_parameters[index].literal_value = parameter.value.literal_value.presence
179+
db_parameters[index].literal_value = parameter.value.literal_value
180180

181181
if parameter.value.node_function_id.present?
182182
node = all_nodes.find { |n| n[:input].id == parameter.value.node_function_id }

spec/requests/graphql/mutation/namespace/projects/flows/update_mutation_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@
7676
{
7777
runtimeParameterDefinitionId: runtime_function.parameters.first.to_global_id.to_s,
7878
value: {
79-
literalValue: 100,
79+
literalValue: [],
8080
},
8181
}
8282
] },

0 commit comments

Comments
 (0)