fix(coding-agent): compact before tool-loop continuation#202
Open
code-yeongyu wants to merge 16 commits into
Open
fix(coding-agent): compact before tool-loop continuation#202code-yeongyu wants to merge 16 commits into
code-yeongyu wants to merge 16 commits into
Conversation
…nal-verify # Conflicts: # packages/coding-agent/CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix tool loops and separate follow-up prompts that cross the compaction threshold after tool results are persisted. Previously, provider call 1 could remain below the threshold while trailing tool results pushed the live context over it; terminating tool batches could then end without next-turn preparation, and the next user prompt trusted stale assistant usage instead of the assembled persisted context.
The runtime now compacts the rebuilt persisted context before every inline continuation or separate pre-prompt dispatch, fails closed when required inline compaction does not complete, preserves provider-bound context transforms and pre-existing next-turn callbacks, and avoids unnecessary preparation for terminating tool batches.
Changes
pre_promptchecks.prepareNextTurnWithContextcallbacks across rebuilt compacted context.QA / Evidence
Final commit:
d96d2b06a263cce3c9147125e081c307db85652f.30/30passed. Evidence:local-ignore/qa-evidence/20260713-compaction-overflow-final-d96d2b06/agent-loop-test.txt.31/31passed. Evidence:local-ignore/qa-evidence/20260713-compaction-overflow-final-d96d2b06/coding-agent-compaction-tests.txt.local-ignore/qa-evidence/20260713-compaction-overflow-final-d96d2b06/npm-run-build.txt.npm run checkexited 0, including TypeScript, browser/web checks, lock validation, and Neo build/vet/tests; no files changed. Evidence:local-ignore/qa-evidence/20260713-compaction-overflow-final-d96d2b06/npm-run-check.txt.9/9, RPC4/4, all mock provider protocols5/5, and the OpenAI Responses two-request tool loop4/4. Every receipt confirms the real auth file was unchanged. Evidence directory:local-ignore/qa-evidence/20260713-compaction-overflow-final-d96d2b06/.origin/main; the added-line audit reports no forbidden patterns. Evidence:local-ignore/qa-evidence/20260713-compaction-overflow-final-d96d2b06/no-excuse-audit.txt.27/28passing with provider call 2 observing zero completed compactions. After the fix, provider call 2 observes one completedpre_promptcompaction and receives rebuilt context.Risks
Secret Safety
Evidence contains no tokens, API keys, auth headers, cookies, environment dumps, or raw secret-bearing service logs. Only sanitized command output and auth-integrity receipts were saved.