test(agent-loader): add tests for parseToolsConfig YAML array and CSV handling

[robinmordasiewicz]

Summary

• Export parseToolsConfig in both agent-loader and plugin-agent-loader for testability
• Add comprehensive test coverage for the YAML array support added in 3e5c69d

Test Cases

• undefined and empty string input → returns undefined
• CSV comma-separated string parsing → boolean map
• YAML array (string[]) parsing → same boolean map
• Whitespace trimming and empty entry filtering
• Case-insensitive key normalization
• Empty array → returns undefined

Changes

• src/features/claude-code-agent-loader/loader.ts — export parseToolsConfig
• src/features/claude-code-plugin-loader/agent-loader.ts — export parseToolsConfig
• src/features/claude-code-agent-loader/parse-tools-config.test.ts — new (10 test cases)
• src/features/claude-code-plugin-loader/parse-tools-config.test.ts — new (10 test cases)

---

Summary by cubic

Adds YAML array and CSV support for the tools field in both agent loaders and adds tests to cover parsing and edge cases. Also introduces an upstream sync workflow and new ops issue templates.

• Bug Fixes

  • parseToolsConfig now accepts string | string[] in both loaders and normalizes keys.
  • Trims whitespace, ignores empty entries, and returns undefined for empty input.
  • Exports parseToolsConfig for testability.
  • Updates types to tools?: string | string[].

• New Features

  • Adds .github/workflows/sync-upstream.yml to auto-merge upstream every 6 hours and rebase ops; creates issues on conflicts.
  • Adds .github/ISSUE_TEMPLATE/ops-task.yml and upstream-contribution.yml for structured ops and upstream work.

^{Written for commit 10acb47. Summary will update on new commits.}

[cubic-dev-ai]

1 issue found across 8 files

Confidence score: 3/5

• There is a concrete medium-risk issue in .github/workflows/sync-upstream.yml: gh api failures are being suppressed, and unknown/error responses can be treated as up-to-date, which may mask real sync breakages.
• The severity/confidence signal (6/10, 8/10) suggests this is more than a cosmetic concern; it can cause silent CI workflow regressions even if application code is unchanged.
• Pay close attention to .github/workflows/sync-upstream.yml - error handling and response classification should fail clearly instead of reporting false up-to-date status.

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".github/workflows/sync-upstream.yml">

<violation number="1" location=".github/workflows/sync-upstream.yml:26">
P2: The workflow suppresses `gh api` failures and misclassifies unknown/error responses as `up-to-date`, which can hide real upstream sync failures.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P2: The workflow suppresses gh api failures and misclassifies unknown/error responses as up-to-date, which can hide real upstream sync failures.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/sync-upstream.yml, line 26:

<comment>The workflow suppresses `gh api` failures and misclassifies unknown/error responses as `up-to-date`, which can hide real upstream sync failures.</comment>

<file context>
@@ -0,0 +1,106 @@
+            --method POST \
+            "repos/${{ github.repository }}/merge-upstream" \
+            -f branch=dev \
+            2>&1) || true
+
+          if echo "$RESPONSE" | grep -q '"merge_type"'; then
</file context>

[code-yeongyu]

Thanks for the test improvements! However, this PR mixes fork-specific infrastructure (.github/ISSUE_TEMPLATE/ops-task.yml, upstream-contribution.yml, sync-upstream.yml) with actual code changes (parseToolsConfig tests).

Could you split this into two PRs?

1. Test-only PR: The parseToolsConfig test improvements (we can merge this)
2. Fork infra PR: The GitHub templates and sync workflow (these are fork-specific and shouldn't go into the main repo)

Happy to merge the test improvements once separated!