Skip to content

fix(rules): preserve picomatch glob compatibility#2

Merged
code-yeongyu merged 1 commit into
mainfrom
ulw/codex-rules-picomatch-followup-20260518
May 18, 2026
Merged

fix(rules): preserve picomatch glob compatibility#2
code-yeongyu merged 1 commit into
mainfrom
ulw/codex-rules-picomatch-followup-20260518

Conversation

@code-yeongyu
Copy link
Copy Markdown
Owner

@code-yeongyu code-yeongyu commented May 18, 2026

Summary

  • Restore picomatch-backed glob matching after the Codex rule baseline merge.
  • Preserve expected Codex rule glob syntax support for character classes and extglobs.

Improvement table

Area Regression after PR #1 Final behavior in this PR Delta / proof
Character-class globs src/**/*.[tj]s compatibility was not preserved by the custom matcher. picomatch with { bash: true, dot: true } matches src/features/app.ts. Regression fixed and pinned in test/matcher.test.ts plus dist smoke.
Extglob syntax `src/**/*.@(ts tsx)` compatibility was missing. Extglob syntax matches src/features/app.tsx.
Runtime dependency contract PR #1 removed runtime glob dependency. picomatch is restored in runtime dependencies; @types/picomatch is dev-only. Package metadata pinned in test/package-smoke.test.ts.
Performance guard Restoring compatibility must not remove benchmark coverage. npm run bench passes after picomatch restoration. Existing benchmark guard remains green.

Verification

  • LSP diagnostics clean on changed TS/test files
  • no-excuse gate passed
  • npm test: 7 files / 52 tests passed
  • npm run check passed
  • npm run bench passed
  • npm pack --dry-run passed
  • dist matcher smoke passed for character classes and extglob patterns

Review

  • Cubic review passed before merge.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 6 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="package.json">

<violation number="1" location="package.json:49">
P2: Adding a runtime dependency violates the repo’s no-production-dependencies convention for marketplace installs.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Re-trigger cubic

Comment thread package.json
"check": "tsc --noEmit && biome check . && npm run build"
},
"dependencies": {
"picomatch": "^4.0.3"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Adding a runtime dependency violates the repo’s no-production-dependencies convention for marketplace installs.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At package.json, line 49:

<comment>Adding a runtime dependency violates the repo’s no-production-dependencies convention for marketplace installs.</comment>

<file context>
@@ -45,9 +45,13 @@
 		"check": "tsc --noEmit && biome check . && npm run build"
 	},
+	"dependencies": {
+		"picomatch": "^4.0.3"
+	},
 	"devDependencies": {
</file context>

@code-yeongyu code-yeongyu merged commit 4999582 into main May 18, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant