Potential fix for code scanning alert no. 1: Workflow does not contain permissions#28
Merged
Potential fix for code scanning alert no. 1: Workflow does not contain permissions#28
Conversation
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/code-gorilla-au/pyrotic/security/code-scanning/1
To fix the problem, we should add a
permissionsblock to the workflow. Since the job only checks out code, installs tools, and runs tests/lint/scan, it does not require write access to repository contents or other resources. The minimal required permission iscontents: read. This can be set either at the workflow level (applies to all jobs) or at the job level (applies only to the specific job). The best practice is to set it at the workflow level unless a job requires different permissions. Therefore, add the following block after thename:field and before theon:field in.github/workflows/pull-request.yaml:No additional imports, methods, or definitions are needed.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.