build(deps): bump nokogiri from 1.18.10 to 1.19.4#998
Conversation
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.18.10 to 1.19.4. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.18.10...v1.19.4) --- updated-dependencies: - dependency-name: nokogiri dependency-version: 1.19.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
The update addresses multiple security advisories and aligns with quality standards according to the Codacy analysis. However, several critical points require attention before merging: the update drops support for certain older runtime environments, and the application test suite has not yet been executed to verify the absence of regressions. Furthermore, an unrelated security vulnerability in a different dependency was identified in the lockfile that should be addressed to ensure overall project security.
About this PR
- Support for older Ruby and JRuby environments has been removed in this update. Ensure the project's runtime environment is compatible to avoid build failures or instability.
- Review the project's version constraint file to ensure it aligns with the security requirements addressed in the lockfile and allows for the necessary updates.
1 comment outside of the diff
Gemfile.lock
line 95🟡 MEDIUM RISK
Suggestion: The component is subject to security vulnerabilities that can lead to lock corruption and incorrect exclusivity, potentially causing race conditions or deadlocks. An update to this component is recommended to mitigate these risks.
Test suggestions
- Verify that the dependency lockfile correctly resolves the dependency to the expected version.
- Execute existing application test suite to ensure no breaking changes or regressions are introduced by the update.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Execute existing application test suite to ensure no breaking changes or regressions are introduced by the update.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
Bumps nokogiri from 1.18.10 to 1.19.4.
Release notes
Sourced from nokogiri's releases.
... (truncated)
Changelog
Sourced from nokogiri's changelog.
Commits
8cfb9daversion bump to v1.19.4a856d1efix: JRuby NONET bypass in XML::Schema (v1.19.x) (#3639)6a0aa1efix(CRuby): use-after-free in Document#encoding= when setter raises (v1.19.x)...f658a54fix: JRuby NONET bypass in XML::Schema39d26fefix(CRuby): use-after-free in Document#encoding= when setter raises04a09ddfix(CRuby): out-of-bounds read in NodeSet#[] with large negative index (v1.19...7799fbdfix: avoid NPE on uninitialized XML::Node structs (v1.19.x) (#3645)ef19e13fix(CRuby): avoid UAF in XML::Attr#value= (v1.19.x) (#3644)5524fa9fix:Document#root=rejects non-element nodes (v1.19.x) (#3643)9891ad1fix(CRuby): use-after-free in XPathContext document lifetime (v1.19.x) (#3641)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.