Bump to 1.17.0 and some new i18n patterns #10
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 1.17.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| ARG OPENGREP_VERSION=v1.17.0 | ||
|
|
||
| # Build codacy-opengrep wrapper | ||
| FROM golang:1.23-alpine3.21 AS builder | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| import datetime | ||
| import locale | ||
| import gettext | ||
|
|
||
| # Set up gettext (only English & French, but French translations missing some keys) | ||
| locales = { | ||
| "en": gettext.translation("messages", localedir="locales", languages=["en"], fallback=True), | ||
| "fr": gettext.translation("messages", localedir="locales", languages=["fr"], fallback=True), | ||
| } | ||
|
|
||
| current_locale = "en" | ||
| _ = locales[current_locale].gettext | ||
|
|
||
| orders = [ | ||
| {"id": 1, "customer": "Alice", "amount": 1234.56, "date": datetime.date.today()}, | ||
| {"id": 2, "customer": "Bob", "amount": 98765.43, "date": datetime.date.today()}, | ||
| ] | ||
|
|
||
|
|
||
| def switch_language(lang): | ||
| global _, current_locale | ||
| if lang in locales: | ||
| current_locale = lang | ||
| _ = locales[lang].gettext | ||
| else: | ||
| print(f"Language {lang} not supported, falling back to English") | ||
|
There was a problem hiding this comment. 🟡 MEDIUM RISK Suggestion: This fallback error message is hardcoded and won't be translated, which is inconsistent with the i18n practices being established. Since the new 'no-hardcoded-print-concat' rule only flags concatenation, this f-string is missed. Use a translation wrapper: |
||
| current_locale = "en" | ||
| _ = locales["en"].gettext | ||
|
|
||
|
|
||
| def add_order(customer, amount): | ||
| today = datetime.date.today() | ||
|
|
||
| # ❌ BAD: Hardcoded English + concatenation | ||
| print("Order for " + customer + " created on " + str(today)) | ||
|
|
||
| # ✅ GOOD: Proper i18n message | ||
| print(_("Order for {customer} created on {date}").format(customer=customer, date=today)) | ||
|
|
||
| orders.append({"id": len(orders) + 1, "customer": customer, "amount": amount, "date": today}) | ||
|
|
||
|
|
||
| def list_orders(): | ||
| print(_("Order List")) | ||
| print("------------") | ||
| for o in orders: | ||
| # ❌ BAD: Hardcoded date format | ||
| print(f"{o['customer']} | {o['date'].strftime('%m/%d/%Y')} | ${o['amount']:.2f}") | ||
|
|
||
| # ✅ GOOD: Locale-aware formatting | ||
| locale.setlocale(locale.LC_ALL, current_locale) | ||
| formatted_date = o['date'].strftime(locale.nl_langinfo(locale.D_FMT)) | ||
| formatted_amount = locale.currency(o['amount'], grouping=True) | ||
|
Comment on lines
+49
to
+53
There was a problem hiding this comment.
|
||
| print(f"{o['customer']} | {formatted_date} | {formatted_amount}") | ||
|
|
||
|
|
||
| def summary(): | ||
| total = sum(o["amount"] for o in orders) | ||
|
|
||
| # ❌ BAD: Hardcoded string | ||
| print("Total Orders: " + str(len(orders))) | ||
| print("Total Revenue: $" + str(total)) | ||
|
|
||
| # ✅ GOOD: Localized message | ||
| print(_("Total Orders: {count}").format(count=len(orders))) | ||
| print(_("Total Revenue: {revenue}").format(revenue=locale.currency(total, grouping=True))) | ||
|
Comment on lines
+64
to
+66
There was a problem hiding this comment.
|
||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| print(_("Welcome to Order Management System")) | ||
|
|
||
| list_orders() | ||
|
|
||
| add_order("Charlie", 555.75) | ||
|
|
||
| print("\nAfter Adding Order:") | ||
| list_orders() | ||
|
|
||
| summary() | ||
|
|
||
| print("\nSwitching to French (missing translations -> fallback):") | ||
| switch_language("fr") | ||
| list_orders() | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI/README build examples pass
--build-arg TOOL_VERSION=$(cat .tool_version), but this Dockerfile only defines/usesOPENGREP_VERSION. As a result, the build arg has no effect and.tool_versioncan drift from the opengrep binary version. Consider renaming the ARG toTOOL_VERSION(or updating CI/docs to passOPENGREP_VERSION) and wiring it through consistently.