Update v25.{1,2,3} AC docs re: short sample setting #21540
Merged
+19
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes DOC-15508 Summary of changes, all related to mentions of the `goschedstats.always_use_short_sample_period.enabled` setting: - Update the v25.1 and v25.2 'Admission Control' pages under the 'Considerations' section to add "To prevent unnecessary queuing in admission control CPU queues, the `goschedstats.always_use_short_sample_period.enabled` setting should be set to `true` for any production cluster." - Update the v25.1 and v25.2 release notes to add the line to the 'Operational changes' subheading "To prevent unnecessary queuing in admission control CPU queues, the `goschedstats.always_use_short_sample_period.enabled` setting should be set to `true` for any production cluster." - Update the v25.3 release notes to mention the change in default value of this setting from `false` to `true`
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
Files changed:
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
rmloveland
commented
Dec 8, 2025
sumeerbhola
approved these changes
Dec 8, 2025
sumeerbhola
left a comment
sumeerbhola
left a comment
There was a problem hiding this comment.
@sumeerbhola reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @nicktrav)
Member
|
This change is |
taroface
reviewed
Dec 9, 2025
src/current/_includes/releases/v25.1/cluster-setting-changes.md
Outdated
Show resolved
Hide resolved
taroface
approved these changes
Dec 9, 2025
Contributor
taroface
left a comment
taroface
left a comment
There was a problem hiding this comment.
LGTM, just left some wording suggestions.
src/current/_includes/releases/v25.1/cluster-setting-changes.md
Outdated
Show resolved
Hide resolved
rmloveland
deleted the
20251208-DOC-15508-ac-goschedstats-always-use-short-sample-period
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DOC-15508
Summary of changes, all related to mentions of the
goschedstats.always_use_short_sample_period.enabledsetting:goschedstats.always_use_short_sample_period.enabledsetting should be set totruefor any production cluster."goschedstats.always_use_short_sample_period.enabledsetting should be set totruefor any production cluster."falsetotrue