Skip to content

Conversation

@rmloveland
Copy link
Contributor

Fixes DOC-15137

@netlify
Copy link

netlify bot commented Dec 8, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 894244e
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/6937241ea4e8ef0008182395

@netlify
Copy link

netlify bot commented Dec 8, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 894244e
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/6937241e69778900083929f5

@netlify
Copy link

netlify bot commented Dec 8, 2025

Deploy Preview for cockroachdb-docs failed. Why did it fail? →

Name Link
🔨 Latest commit 894244e
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/6937241eddcb37000860c35c

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

Files changed:

@rmloveland rmloveland requested a review from msbutler December 8, 2025 19:17
@rmloveland
Copy link
Contributor Author

@msbutler please let me know for what previous versions this change also applies. I'd naively assume v24.1+ ? but please confirm

once we're happy with the change i'll backport to the supported prior versions

Copy link
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one optional suggestion, and pending the versions to backport being clarified. Note that we have 26.1 now!

- [`COPY`]({% link {{ page.version.version }}/copy.md %}) statements.
- [Deletes]({% link {{ page.version.version }}/delete-data.md %}) (including deletes initiated by [row-level TTL jobs]({% link {{ page.version.version }}/row-level-ttl.md %}); the [selection queries]({% link {{ page.version.version }}/selection-queries.md %}) performed by TTL jobs are also subject to CPU admission control).
- [Backups]({% link {{ page.version.version }}/backup-and-restore-overview.md %}).
- [`RESTORE`]({% link {{ page.version.version }}/restore.md %}) operations, including [full cluster]({% link {{ page.version.version }}/restore.md %}#full-cluster), [database]({% link {{ page.version.version }}/restore.md %}#databases), and [table]({% link {{ page.version.version }}/restore.md %}#tables) restores.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just for consistency with "Backups" not using the SQL syntax. But optional.

Suggested change
- [`RESTORE`]({% link {{ page.version.version }}/restore.md %}) operations, including [full cluster]({% link {{ page.version.version }}/restore.md %}#full-cluster), [database]({% link {{ page.version.version }}/restore.md %}#databases), and [table]({% link {{ page.version.version }}/restore.md %}#tables) restores.
- [Restore]({% link {{ page.version.version }}/restore.md %}) operations, including [full cluster]({% link {{ page.version.version }}/restore.md %}#full-cluster), [database]({% link {{ page.version.version }}/restore.md %}#databases), and [table]({% link {{ page.version.version }}/restore.md %}#tables) restores.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants