Skip to content

parser: Fix EncFirstFreeFlagBit #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jeremyyang920 merged 1 commit into from
Jun 16, 2025
Merged

parser: Fix EncFirstFreeFlagBit #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions patches/0005-enc-first-free-flag.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
diff --git a/pkg/sql/lexbase/encode.go b/pkg/sql/lexbase/encode.go
index 47b9a37..4f7bc03 100644
--- a/pkg/sql/lexbase/encode.go
+++ b/pkg/sql/lexbase/encode.go
@@ -46,14 +46,14 @@ const (
// without wrapping quotes.
EncBareReservedKeywords

- // EncFirstFreeFlagBit needs to remain unused; it is used as base
- // bit offset for tree.FmtFlags.
- EncFirstFreeFlagBit
-
// EncAlwaysQuoted makes sure the string is always wrapped with quotes.
// This is used only to construct a statement against Oracle source,
// as Oracle is case insensitive if object name is not quoted.
EncAlwaysQuoted
+
+ // EncFirstFreeFlagBit needs to remain unused; it is used as base
+ // bit offset for tree.FmtFlags.
+ EncFirstFreeFlagBit
)

// EncodeRestrictedSQLIdent writes the identifier in s to buf. The
8 changes: 4 additions & 4 deletions pkg/sql/lexbase/encode.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,14 @@ const (
// without wrapping quotes.
EncBareReservedKeywords

// EncFirstFreeFlagBit needs to remain unused; it is used as base
// bit offset for tree.FmtFlags.
EncFirstFreeFlagBit

// EncAlwaysQuoted makes sure the string is always wrapped with quotes.
// This is used only to construct a statement against Oracle source,
// as Oracle is case insensitive if object name is not quoted.
EncAlwaysQuoted

// EncFirstFreeFlagBit needs to remain unused; it is used as base
// bit offset for tree.FmtFlags.
EncFirstFreeFlagBit
)

// EncodeRestrictedSQLIdent writes the identifier in s to buf. The
Expand Down
2 changes: 1 addition & 1 deletion version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
259c8a573eb2ba28643ffd55ee3bf6a438198c04
4822ed2001ffba40aa96839344ffffad92020a2e