bulkmerge: gate distributed merge on instance availability#162616
Draft
spilchen wants to merge 1 commit intocockroachdb:masterfrom
Draft
bulkmerge: gate distributed merge on instance availability#162616spilchen wants to merge 1 commit intocockroachdb:masterfrom
spilchen wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Previously, a distributed merge would fail immediately if any SQL instance owning required SST files was unavailable (for example, when a node was down). If the instance remained unavailable, the job would retry indefinitely and never make progress. This change adds a proactive availability check at the start of Merge(). Before planning the merge, we now verify that all required nodes are up. If any are unavailable, the job enters an exponential backoff. If the backoff expires, the job fails with a permanent error so that it does not restart endlessly. The logic lives in the bulkmerge package so that this behavior applies consistently to IMPORT and backfill. Epic: CRDB-48845 Closes cockroachdb#161877 Release note: None
Contributor
|
Merging to
|
Member
|
This change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, a distributed merge would fail immediately if any SQL instance owning required SST files was unavailable (for example, when a node was down). If the instance remained unavailable, the job would retry indefinitely and never make progress.
This change adds a proactive availability check at the start of Merge(). Before planning the merge, we now verify that all required nodes are up. If any are unavailable, the job enters an exponential backoff. If the backoff expires, the job fails with a permanent error so that it does not restart endlessly.
The logic lives in the bulkmerge package so that this behavior applies consistently to IMPORT and backfill.
Epic: CRDB-48845
Closes #161877
Release note: None