ui: convert jobs/schedule page class components to functional components#162597
Merged
trunk-io[bot] merged 1 commit intocockroachdb:masterfrom Feb 11, 2026
Merged
Conversation
Contributor
|
😎 Merged successfully - details. |
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
jasonlmfong
requested review from
dhartunian and
kyle-a-wong
and removed request for
a team
dhartunian
approved these changes
Feb 10, 2026
Collaborator
dhartunian
left a comment
dhartunian
left a comment
There was a problem hiding this comment.
@dhartunian reviewed all commit messages and made 1 comment.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @kyle-a-wong).
dhartunian
approved these changes
Feb 10, 2026
Collaborator
dhartunian
left a comment
dhartunian
left a comment
There was a problem hiding this comment.
@dhartunian made 1 comment.
Reviewable status:
This change converts the following class components into their functional style equivalent: - jobsPage - jobDetails - jobDescriptionCell - scheduleTable - indexDetailsPage - duration - highwaterTimestamp - progressBar The conversion was done by iteratively using a claude skill, and no human intervention was needed. Existing Enzyme + Chai tests were converted into pure react-testing-library tests. The affected pages have been manually verified and cypress tested. Epic: CRDB-58145 Release Note: None
jasonlmfong
force-pushed
the
jf/console-job-func
branch
from
212fdfa to
65a2499
Compare
Member
Author
|
/trunk merge |
celeste-cockroachdb
Bot
added
v26.2.0-prerelease
and removed
target-release-26.2.0
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change converts the following class components into their functional style equivalent:
The conversion was done by iteratively using a claude skill, and no human intervention was needed.
Existing Enzyme tests were converted into pure react-testing-library tests. The affected pages have been manually verified and cypress tested.
Epic: CRDB-58145
Release Note: None