roachprod-microbench, testutils: lint benchdocs#162595
Draft
herkolategan wants to merge 2 commits intocockroachdb:masterfrom
Draft
roachprod-microbench, testutils: lint benchdocs#162595herkolategan wants to merge 2 commits intocockroachdb:masterfrom
herkolategan wants to merge 2 commits intocockroachdb:masterfrom
Conversation
Previously, if an engineer added args to their benchmark documentation, there was no validation to ensure the formatting was correct. This PR moves the benchmark doc args parsing to a shared utility in testutils and also adds a linter to verify all benchmark docs. This takes the guessing out of adding a benchmark doc and hoping for the best when the weekly microbenchmarks run. The weekly job will use the lenient mode, with the expectation that any merged code (benchmark docs) would have gone through the linter. Epic: None Release Note: None
Previously, roachprod-microbench had no way to pass per-benchmark configuration (such as benchtime) when executing benchmarks. All benchmarks ran with the same default arguments regardless of their benchmark-ci documentation annotations. This change adds: - CompareArgs to BenchmarkInfo, supporting `post` (none/blocker) and `threshold` (0.0-1.0) configuration keys in benchmark-ci annotations. - JSON serialization tags on BenchmarkInfo, RunArgs, and CompareArgs to support import/export of benchmark configurations. - A `--export` flag on the `list` command to export the benchmark list to a JSON file. - A `--benchmark-config` flag on the `run` command to load a JSON benchmark config and apply per-benchmark settings (e.g. benchtime) when generating test commands. Not all the `CompareArgs` and `RunArgs` are functional, yet, this will be implemented in a follow-up PR. Epic: None Release note: None
Contributor
|
Merging to
|
Member
|
This change is |
Member
🔴 Sysbench [SQL, 3node, oltp_read_write]
Reproducebenchdiff binaries: mkdir -p benchdiff/69a0cb2/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/69a0cb280706e3c61f4974f364bbf3408909d6e8/bin/pkg_sql_tests benchdiff/69a0cb2/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/69a0cb2/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/f275471/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/f2754717ca1ec136f609fdfa5ca779e0fbf120e1/bin/pkg_sql_tests benchdiff/f275471/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/f275471/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/SQL/3node/oltp_read_write$ --old=f275471 --new=69a0cb2 ./pkg/sql/tests⚪ Sysbench [KV, 3node, oltp_read_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/69a0cb2/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/69a0cb280706e3c61f4974f364bbf3408909d6e8/bin/pkg_sql_tests benchdiff/69a0cb2/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/69a0cb2/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/f275471/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/f2754717ca1ec136f609fdfa5ca779e0fbf120e1/bin/pkg_sql_tests benchdiff/f275471/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/f275471/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_read_only$ --old=f275471 --new=69a0cb2 ./pkg/sql/tests⚪ Sysbench [KV, 3node, oltp_write_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/69a0cb2/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/69a0cb280706e3c61f4974f364bbf3408909d6e8/bin/pkg_sql_tests benchdiff/69a0cb2/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/69a0cb2/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/f275471/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/f2754717ca1ec136f609fdfa5ca779e0fbf120e1/bin/pkg_sql_tests benchdiff/f275471/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/f275471/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_write_only$ --old=f275471 --new=69a0cb2 ./pkg/sql/testsArtifactsdownload: mkdir -p new
gcloud storage cp gs://cockroach-microbench-ci/artifacts/69a0cb280706e3c61f4974f364bbf3408909d6e8/21755070543-1/\* new/
mkdir -p old
gcloud storage cp gs://cockroach-microbench-ci/artifacts/f2754717ca1ec136f609fdfa5ca779e0fbf120e1/21755070543-1/\* old/built with commit: 69a0cb280706e3c61f4974f364bbf3408909d6e8 |
cockroach-teamcity
added
the
X-perf-check
Member
⚪ Sysbench [SQL, 3node, oltp_read_write]
Reproducebenchdiff binaries: mkdir -p benchdiff/69a0cb2/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/69a0cb280706e3c61f4974f364bbf3408909d6e8/bin/pkg_sql_tests benchdiff/69a0cb2/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/69a0cb2/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/f275471/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/f2754717ca1ec136f609fdfa5ca779e0fbf120e1/bin/pkg_sql_tests benchdiff/f275471/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/f275471/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/SQL/3node/oltp_read_write$ --old=f275471 --new=69a0cb2 ./pkg/sql/tests⚪ Sysbench [KV, 3node, oltp_read_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/69a0cb2/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/69a0cb280706e3c61f4974f364bbf3408909d6e8/bin/pkg_sql_tests benchdiff/69a0cb2/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/69a0cb2/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/f275471/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/f2754717ca1ec136f609fdfa5ca779e0fbf120e1/bin/pkg_sql_tests benchdiff/f275471/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/f275471/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_read_only$ --old=f275471 --new=69a0cb2 ./pkg/sql/tests⚪ Sysbench [KV, 3node, oltp_write_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/69a0cb2/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/69a0cb280706e3c61f4974f364bbf3408909d6e8/bin/pkg_sql_tests benchdiff/69a0cb2/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/69a0cb2/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/f275471/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/f2754717ca1ec136f609fdfa5ca779e0fbf120e1/bin/pkg_sql_tests benchdiff/f275471/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/f275471/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_write_only$ --old=f275471 --new=69a0cb2 ./pkg/sql/testsArtifactsdownload: mkdir -p new
gcloud storage cp gs://cockroach-microbench-ci/artifacts/69a0cb280706e3c61f4974f364bbf3408909d6e8/21755070543-2/\* new/
mkdir -p old
gcloud storage cp gs://cockroach-microbench-ci/artifacts/f2754717ca1ec136f609fdfa5ca779e0fbf120e1/21755070543-2/\* old/built with commit: 69a0cb280706e3c61f4974f364bbf3408909d6e8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.