-
Notifications
You must be signed in to change notification settings - Fork 2
Add get-workflow-ref action #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| name: Get Workflow Ref | ||
| description: > | ||
| Resolve the ref that a caller used to invoke a reusable workflow from this | ||
| repo. Parses the caller's workflow file — no API calls or extra permissions | ||
| needed. | ||
|
|
||
| inputs: | ||
| workflow_name: | ||
| description: > | ||
| Substring to match in the caller's uses line (e.g. | ||
| "cockroachdb/actions/.github/workflows/github-issue-autosolve.yml"). | ||
| required: true | ||
|
|
||
| outputs: | ||
| ref: | ||
| description: The ref (tag, branch, or SHA) from the caller's uses line. | ||
| value: ${{ steps.resolve.outputs.ref }} | ||
|
|
||
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - name: Checkout caller workflows | ||
| uses: actions/checkout@v6 | ||
| with: | ||
| sparse-checkout: .github/workflows | ||
| persist-credentials: false | ||
| path: __get-workflow-ref | ||
|
|
||
| - name: Resolve ref from caller workflow | ||
| id: resolve | ||
| shell: bash | ||
| working-directory: __get-workflow-ref | ||
| run: bash "$GITHUB_ACTION_PATH/resolve_ref.sh" | ||
| env: | ||
| WORKFLOW_REF: ${{ github.workflow_ref }} | ||
| REPO: ${{ github.repository }} | ||
| REF: ${{ github.ref }} | ||
| WORKFLOW_NAME: ${{ inputs.workflow_name }} | ||
|
|
||
| - name: Cleanup | ||
| shell: bash | ||
| run: rm -rf __get-workflow-ref | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| #!/usr/bin/env bash | ||
| # Resolve the ref a caller used to invoke a reusable workflow. | ||
| # | ||
| # Required env vars: | ||
| # WORKFLOW_REF — github.workflow_ref (e.g. owner/repo/.github/workflows/caller.yml@refs/heads/main) | ||
| # REPO — github.repository (e.g. owner/repo) | ||
| # REF — github.ref (e.g. refs/heads/main) | ||
| # WORKFLOW_NAME — substring to match in the caller's uses line | ||
| # | ||
| # Outputs (appended to $GITHUB_OUTPUT): | ||
| # ref — the resolved ref string | ||
| set -euo pipefail | ||
|
|
||
| SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")"; pwd)" | ||
| # shellcheck source=../actions_helpers.sh | ||
| source "$SCRIPT_DIR/../actions_helpers.sh" | ||
|
|
||
| workflow_ref="${WORKFLOW_REF}" | ||
|
|
||
| # Strip "owner/repo/" prefix and "@refs/..." suffix to get the | ||
| # caller's workflow file path. | ||
| workflow_path="${workflow_ref#"${REPO}/"}" | ||
| workflow_path="${workflow_path%@*}" | ||
|
|
||
| if [ ! -f "$workflow_path" ]; then | ||
| log_error "Could not find caller workflow at: $workflow_path" | ||
| exit 1 | ||
| fi | ||
|
|
||
| # Find the uses: line that references our workflow and extract the ref. | ||
| # Filter to uses: lines first (avoids matching comments or job names), | ||
| # then match the workflow name as a literal string. | ||
| if ! match="$(grep 'uses:' "$workflow_path" | grep --fixed-strings -- "$WORKFLOW_NAME" | head -1)"; then | ||
| log_error "Could not find '$WORKFLOW_NAME' in $workflow_path" | ||
| exit 1 | ||
| fi | ||
|
|
||
| # Handle local reference (./): use the caller's own ref. | ||
| if [[ "$match" == *"./.github/workflows"* ]]; then | ||
| ref="${REF}" | ||
| else | ||
| ref="$(printf '%s\n' "$match" | sed 's/.*@//' | awk '{print $1}')" | ||
| fi | ||
|
|
||
| if [ -z "$ref" ]; then | ||
| log_error "Could not parse ref from: $match" | ||
| exit 1 | ||
| fi | ||
|
|
||
| set_output "ref" "$ref" | ||
| log_notice "Resolved workflow ref: $ref" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,209 @@ | ||
| #!/usr/bin/env bash | ||
| # Tests for resolve_ref.sh | ||
| set -euo pipefail | ||
|
|
||
| cd "$(dirname "${BASH_SOURCE[0]}")" | ||
| SCRIPT_DIR="$PWD" | ||
| source ../test_helpers.sh | ||
|
|
||
| TMPDIR=$(mktemp -d) | ||
| trap 'rm -rf "$TMPDIR"' EXIT | ||
| cd "$TMPDIR" | ||
|
|
||
| export GITHUB_OUTPUT="$TMPDIR/github_output.txt" | ||
|
|
||
| reset_output() { | ||
| : > "$GITHUB_OUTPUT" | ||
| } | ||
|
|
||
| get_ref() { | ||
| grep "ref=" "$GITHUB_OUTPUT" | cut -d= -f2 | ||
| } | ||
|
|
||
| # Helper: create a caller workflow file with the given uses line. | ||
| make_workflow() { | ||
| local path="$TMPDIR/$1" | ||
| mkdir -p "$(dirname "$path")" | ||
| cat > "$path" <<EOF | ||
| name: Caller | ||
| on: workflow_dispatch | ||
| jobs: | ||
| call: | ||
| uses: $2 | ||
| EOF | ||
| } | ||
|
|
||
| # ============================================= | ||
| # Basic ref resolution | ||
| # ============================================= | ||
|
|
||
| reset_output | ||
| test_basic_tag_ref() { | ||
| make_workflow ".github/workflows/caller.yml" \ | ||
| "cockroachdb/actions/.github/workflows/autosolve.yml@v1.2.3" | ||
| env WORKFLOW_REF="myorg/myrepo/.github/workflows/caller.yml@refs/heads/main" \ | ||
| REPO="myorg/myrepo" \ | ||
| REF="refs/heads/main" \ | ||
| WORKFLOW_NAME="autosolve.yml" \ | ||
| "$SCRIPT_DIR/resolve_ref.sh" | ||
| [ "$(get_ref)" = "v1.2.3" ] | ||
| } | ||
| expect_success "basic: resolves tag ref" test_basic_tag_ref | ||
|
|
||
| reset_output | ||
| test_basic_branch_ref() { | ||
| make_workflow ".github/workflows/caller.yml" \ | ||
| "cockroachdb/actions/.github/workflows/autosolve.yml@main" | ||
| env WORKFLOW_REF="myorg/myrepo/.github/workflows/caller.yml@refs/heads/main" \ | ||
| REPO="myorg/myrepo" \ | ||
| REF="refs/heads/main" \ | ||
| WORKFLOW_NAME="autosolve.yml" \ | ||
| "$SCRIPT_DIR/resolve_ref.sh" | ||
| [ "$(get_ref)" = "main" ] | ||
| } | ||
| expect_success "basic: resolves branch ref" test_basic_branch_ref | ||
|
|
||
| reset_output | ||
| test_basic_sha_ref() { | ||
| make_workflow ".github/workflows/caller.yml" \ | ||
| "cockroachdb/actions/.github/workflows/autosolve.yml@abc123def456" | ||
| env WORKFLOW_REF="myorg/myrepo/.github/workflows/caller.yml@refs/heads/main" \ | ||
| REPO="myorg/myrepo" \ | ||
| REF="refs/heads/main" \ | ||
| WORKFLOW_NAME="autosolve.yml" \ | ||
| "$SCRIPT_DIR/resolve_ref.sh" | ||
| [ "$(get_ref)" = "abc123def456" ] | ||
| } | ||
| expect_success "basic: resolves SHA ref" test_basic_sha_ref | ||
|
|
||
| reset_output | ||
| test_slash_branch_ref() { | ||
| make_workflow ".github/workflows/caller.yml" \ | ||
| "cockroachdb/actions/.github/workflows/autosolve.yml@pr/autosolve-workflow" | ||
| env WORKFLOW_REF="myorg/myrepo/.github/workflows/caller.yml@refs/heads/main" \ | ||
| REPO="myorg/myrepo" \ | ||
| REF="refs/heads/main" \ | ||
| WORKFLOW_NAME="autosolve.yml" \ | ||
| "$SCRIPT_DIR/resolve_ref.sh" | ||
| [ "$(get_ref)" = "pr/autosolve-workflow" ] | ||
| } | ||
| expect_success "basic: resolves slash-branch ref" test_slash_branch_ref | ||
|
|
||
| # ============================================= | ||
| # Local ./ reference | ||
| # ============================================= | ||
|
|
||
| reset_output | ||
| test_local_ref() { | ||
| make_workflow ".github/workflows/caller.yml" \ | ||
| "./.github/workflows/autosolve.yml" | ||
| env WORKFLOW_REF="myorg/myrepo/.github/workflows/caller.yml@refs/heads/main" \ | ||
| REPO="myorg/myrepo" \ | ||
| REF="refs/heads/main" \ | ||
| WORKFLOW_NAME="autosolve.yml" \ | ||
| "$SCRIPT_DIR/resolve_ref.sh" | ||
| [ "$(get_ref)" = "refs/heads/main" ] | ||
| } | ||
| expect_success "local: ./ reference uses caller ref" test_local_ref | ||
|
|
||
| # ============================================= | ||
| # Bug: pull_request event — github.ref != workflow_ref suffix | ||
| # | ||
| # On pull_request, github.ref is refs/pull/42/merge but | ||
| # github.workflow_ref ends with @refs/heads/main. | ||
| # The current code strips "@${REF}" which won't match, | ||
| # leaving the @refs/heads/main suffix in the path. | ||
| # ============================================= | ||
|
|
||
| reset_output | ||
| test_pr_event_ref_mismatch() { | ||
| make_workflow ".github/workflows/caller.yml" \ | ||
| "cockroachdb/actions/.github/workflows/autosolve.yml@v2.0.0" | ||
| env WORKFLOW_REF="myorg/myrepo/.github/workflows/caller.yml@refs/heads/main" \ | ||
| REPO="myorg/myrepo" \ | ||
| REF="refs/pull/42/merge" \ | ||
| WORKFLOW_NAME="autosolve.yml" \ | ||
| "$SCRIPT_DIR/resolve_ref.sh" | ||
| [ "$(get_ref)" = "v2.0.0" ] | ||
| } | ||
| expect_success "pr event: ref mismatch between github.ref and workflow_ref" test_pr_event_ref_mismatch | ||
|
|
||
| # ============================================= | ||
| # Bug: grep treats workflow_name as regex | ||
| # | ||
| # "autosolve.yml" as regex: the dot matches any char, so it | ||
| # matches "autosolvexyml". With fixed-string grep it should NOT | ||
| # match, and the script should fail. | ||
| # ============================================= | ||
|
|
||
| reset_output | ||
| test_grep_regex_false_positive() { | ||
| local path="$TMPDIR/.github/workflows/caller.yml" | ||
| mkdir -p "$(dirname "$path")" | ||
| cat > "$path" <<'EOF' | ||
| name: Caller | ||
| on: workflow_dispatch | ||
| jobs: | ||
| call: | ||
| uses: cockroachdb/actions/.github/workflows/autosolvexyml@v1.0.0 | ||
| EOF | ||
| env WORKFLOW_REF="myorg/myrepo/.github/workflows/caller.yml@refs/heads/main" \ | ||
| REPO="myorg/myrepo" \ | ||
| REF="refs/heads/main" \ | ||
| WORKFLOW_NAME="autosolve.yml" \ | ||
| "$SCRIPT_DIR/resolve_ref.sh" | ||
| } | ||
| expect_failure "grep regex: dot in name should not match arbitrary char" test_grep_regex_false_positive | ||
|
|
||
| # ============================================= | ||
| # Only match uses: lines, not comments or job names | ||
| # ============================================= | ||
|
|
||
| reset_output | ||
| test_ignores_comments_and_job_names() { | ||
| local path="$TMPDIR/.github/workflows/caller.yml" | ||
| mkdir -p "$(dirname "$path")" | ||
| cat > "$path" <<'EOF' | ||
| name: Caller | ||
| on: workflow_dispatch | ||
| jobs: | ||
| # This job calls autosolve.yml to fix issues | ||
| autosolve.yml-runner: | ||
| uses: cockroachdb/actions/.github/workflows/autosolve.yml@v3.0.0 | ||
| EOF | ||
| env WORKFLOW_REF="myorg/myrepo/.github/workflows/caller.yml@refs/heads/main" \ | ||
| REPO="myorg/myrepo" \ | ||
| REF="refs/heads/main" \ | ||
| WORKFLOW_NAME="autosolve.yml" \ | ||
| "$SCRIPT_DIR/resolve_ref.sh" | ||
| [ "$(get_ref)" = "v3.0.0" ] | ||
| } | ||
| expect_success "uses-only: ignores comments and job names, matches uses: line" test_ignores_comments_and_job_names | ||
|
|
||
| # ============================================= | ||
| # Error cases | ||
| # ============================================= | ||
|
|
||
| reset_output | ||
| test_missing_workflow_file() { | ||
| env WORKFLOW_REF="myorg/myrepo/.github/workflows/nonexistent.yml@refs/heads/main" \ | ||
| REPO="myorg/myrepo" \ | ||
| REF="refs/heads/main" \ | ||
| WORKFLOW_NAME="autosolve.yml" \ | ||
| "$SCRIPT_DIR/resolve_ref.sh" | ||
| } | ||
| expect_failure "error: missing workflow file" "Could not find caller workflow" test_missing_workflow_file | ||
|
|
||
| reset_output | ||
| test_workflow_name_not_found() { | ||
| make_workflow ".github/workflows/caller.yml" \ | ||
| "cockroachdb/actions/.github/workflows/other.yml@v1.0.0" | ||
| env WORKFLOW_REF="myorg/myrepo/.github/workflows/caller.yml@refs/heads/main" \ | ||
| REPO="myorg/myrepo" \ | ||
| REF="refs/heads/main" \ | ||
| WORKFLOW_NAME="nonexistent-workflow.yml" \ | ||
| "$SCRIPT_DIR/resolve_ref.sh" | ||
| } | ||
| expect_failure "error: workflow name not found" "Could not find 'nonexistent-workflow.yml'" test_workflow_name_not_found | ||
|
|
||
| print_results |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.