HypervisorMaintenance: Trigger eviction based on maintenance flag#182
Merged
HypervisorMaintenance: Trigger eviction based on maintenance flag#182
Conversation
notandy
requested changes
Nov 18, 2025
a6999a0 to
9a7fee7
Compare
9a7fee7 to
e6dc936
Compare
notandy
requested changes
Nov 18, 2025
Contributor
There was a problem hiding this comment.
I think we need to have a call about this implementation.
The controller want's to take care of:
- Eviction condition
- the evicted status field probably makes also most sense in the eviction controller itself
- ready status
and conflicts with the other controllers, but it doesn't cleanup / remove stuff from other controllers. This feels too complex to be reviewed by me currently
When maintenance is set, it will trigger an eviction via the respective CRD and reflect the result back to the hypervisor status.
e6dc936 to
64f9483
Compare
Contributor
Author
|
I've used semantic equality, as controller-runtime also switched to that. I vaguely had in the back of my mind that there was some problem with |
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
notandy
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When maintenance is set, it will trigger an eviction via the respective CRD and reflect the result back to the hypervisor status.