Conversation
Collaborator
umswmayj
commented
Mar 24, 2026
umswmayj
commented
- Better committed resource logging (Better committed resource logging #620)
- Enable kvm_failover_evacuation weigher (Enable kvm_failover_evacuation weigher #618)
- Fix filter capabilities mutating flavor extra specs
The filter was directly assigning `request.Spec.Data.Flavor.Data.ExtraSpecs` to a local variable and then using `delete()` to remove non-capability keys. The filter was directly assigning `request.Spec.Data.Flavor.Data.ExtraSpecs` to a local variable and then using `delete()` to remove non-capability keys. The fix was to change the code to extract only capability keys into a new map instead of deleting from the original.
umswmayj
requested review from
PhilippMatthes,
SoWieMarkus,
auhlig,
juliusclausnitzer and
mblos
as code owners
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
PhilippMatthes
approved these changes
Mar 24, 2026
Member
|
Disabled auto merge just in case someone merges another change into main and that makes a race condition with the github actions bot. |
Contributor
Test Coverage ReportTest Coverage 📊: 68.5% |
PhilippMatthes
approved these changes
Mar 25, 2026
SoWieMarkus
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.