WIP: labhub: Allow missing username and msg link#417
Open
jayvdb wants to merge 1 commit intocoala:masterfrom
Open
WIP: labhub: Allow missing username and msg link#417jayvdb wants to merge 1 commit intocoala:masterfrom
jayvdb wants to merge 1 commit intocoala:masterfrom
Conversation
Member
Author
|
The mocking isnt working :/ |
Some backends do not provide usernames or msg links. Zulip and Slack both using msg.extra['url'], and a patch is pending for the gitter backend to follow suite. errbotio/err-backend-gitter#32 Fixes coala#392 Related to coala#255
Vamshi99
reviewed
Nov 29, 2017
| testbot.assertCommand('!new issue repository.github.io another title\nand body', | ||
| 'Here you go') | ||
| msg = Message('!new issue repository.github.io another title\nand body', | ||
| 'Here you go') |
Member
There was a problem hiding this comment.
@jayvdb Invalid command args, it can be like
msg = Message('!new issue repository.github.io another title\nand body')
testbot.assertCommand(msg.body, 'Here you go')
Member
There was a problem hiding this comment.
I didn't, I can say that from the errbot documentation, just change constructor and add assert command.
Vamshi99
reviewed
Nov 29, 2017
| 'Here you go') | ||
| msg.extras['url'] = 'http://example.com' | ||
| msg.frm = testbot.bot.build_identifier('Jo') | ||
| msg.frm._nick = 'jo' |
Member
There was a problem hiding this comment.
msg.frm._nick --> msg.frm.nick
Member
Author
There was a problem hiding this comment.
I am pretty sure it is a non-writable property.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some backends do not provide usernames or msg links.
Zulip and Slack both using msg.extra['url'], and a
patch is pending for the gitter backend to follow suite.
errbotio/err-backend-gitter#32
Fixes #392
Related to #255