Proposal for upstreaming Siemens Energy patches#263
Open
krake-SE wants to merge 8 commits intocneben:developfrom
Open
Proposal for upstreaming Siemens Energy patches#263krake-SE wants to merge 8 commits intocneben:developfrom
krake-SE wants to merge 8 commits intocneben:developfrom
Conversation
This way we can "redirect" QML files from third party libraries to a common directory, and add that to QML_IMPORT_PATH.
Needed an update due to changes in Qt 6.8, and ideally should not be required as AUTOMOC is supposed to take of it automagically. https://doc.qt.io/qt-6/qt-wrap-cpp.html https://cmake.org/cmake/help/latest/manual/cmake-qt.7.html#automoc
Without this change, the edges will not use the style unless the style changes at least once.
- New edge type OrthoCustom that only considers the horizontal layout case. - New style property orthoCustomRadius to customize the path radius. - A control point is computed in the middle, then the edge is drawn through it with a couple of lines and arcs.
* Add separate orthoRoundedLine property on the shapes for consistency with other code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We at Siemens Energy have been using QuickQanava for a couple of months and accumulated a couple of changes.
Some of them, or maybe even all, might be of general interest to upstream and we have successfully convinced management and legal to let us go ahead with PR submission.
This branch/PR contains the full set in chronological order, so we are prepared to create alternative/modified submissions for any sub-set you would be interested in.