Merged
Conversation
Signed-off-by: thisisobate <obasiuche62@gmail.com>
✅ Deploy Preview for cncf-techdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: thisisobate <obasiuche62@gmail.com>
chalin
requested changes
Jan 7, 2026
Collaborator
chalin
left a comment
chalin
left a comment
There was a problem hiding this comment.
@thisisobate - I'm not seeing any build errors elsewhere, so I'm not sure that these updates are required. Are you sure you're using the LTS version of Node?
Collaborator
|
Oooh, I see what's happening. You're probably not using the versions of the packages declared in this repo. Let me fix that. |
chalin
reviewed
Jan 7, 2026
| --- | ||
|
|
||
| <!-- markdownlint-disable no-duplicate-heading --> | ||
| <!-- markdownlint-disable-file --> |
Collaborator
There was a problem hiding this comment.
Why disable mdl for the entire file?
chalin
reviewed
Jan 7, 2026
| author: Dave Welsch (@dwelsch-esi) | ||
| --- | ||
|
|
||
| <!-- markdownlint-disable --> |
Collaborator
There was a problem hiding this comment.
Why disable this for the entire file?
chalin
approved these changes
Jan 7, 2026
Collaborator
chalin
left a comment
chalin
left a comment
There was a problem hiding this comment.
Ok, let's merge this as is, and I'll re-enable markdown checks along with other fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.