Conversation
VarshaUN
requested review from
Okabe-Junya,
caniszczyk,
hlipsig,
jihoon-seo,
nate-double-u and
seokho-son
as code owners
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-project-automation
bot
moved this to 📋 Backlog
in CNCF glossary definition review board
Signed-off-by: Varsha U N <varshaun58@gmail.com> Signed-off-by: VarshaUN <varshaun58@gmail.com>
|
@caniszczyk kindly review this |
Okabe-Junya
left a comment
Okabe-Junya
left a comment
There was a problem hiding this comment.
Thank you for your work 👍
left some comments, PTAL when you have time
| tags: ["application", "fundamental", ""] | ||
| --- | ||
|
|
||
| An image digest is a unique, content-based identifier for a [container image](/container/), |
There was a problem hiding this comment.
| An image digest is a unique, content-based identifier for a [container image](/container/), | |
| An image digest is a unique, content-based identifier for a [container image](/container-image/), |
I think, we have a page for container image - https://glossary.cncf.io/container-image/
| title: Image Digest | ||
| status: Completed | ||
| category: concept | ||
| tags: ["application", "fundamental", ""] |
There was a problem hiding this comment.
| tags: ["application", "fundamental", ""] | |
| tags: ["application", "fundamental"] |
nit
There was a problem hiding this comment.
And I think image digest is not "fundamental",
How about "security" instead?
| teams ensure they are always running the exact same image, | ||
| regardless of what happens to its tag. | ||
| This is especially important for security audits, reproducible builds, | ||
| and [supply chain](/cloud-native-security/) integrity in production environments. No newline at end of file |
There was a problem hiding this comment.
| and [supply chain](/cloud-native-security/) integrity in production environments. | |
| and supply chain integrity in production environments. |
I think we don't need to link to "Cloud Native security" page
| teams ensure they are always running the exact same image, | ||
| regardless of what happens to its tag. | ||
| This is especially important for security audits, reproducible builds, | ||
| and [supply chain](/cloud-native-security/) integrity in production environments. No newline at end of file |
There was a problem hiding this comment.
You can add ## Related terms sectons (container image, container)
There was a problem hiding this comment.
Just a small suggestion: the intro and the "Problem it addresses" section have some overlap regarding "tag vs. digest."
I recommend focusing the "Problem ..." section strictly on the risks of tag mutability (security/reproducibility) and moving any solution-related details to "How it helps" for better flow, WDYT?
| tags: ["application", "fundamental", ""] | ||
| --- | ||
|
|
||
| An image digest is a unique, content-based identifier for a [container image](/container/), |
There was a problem hiding this comment.
content-based identifier
I think "content-addressable identity" would be better word based on OCI spec
There was a problem hiding this comment.
I think it would be good to mention "OCI" in this document (e.g.,
Okabe-Junya
left a comment
Okabe-Junya
left a comment
There was a problem hiding this comment.
Looks CI is red - https://github.com/cncf/glossary/actions/runs/23579394564/job/70831152685?pr=3627
Could you also fix this?
2 participants
Describe your changes
Related issue number or link (ex:
resolves #issue-number)This PR resolves kubernetes/website#55017
Checklist before opening this PR (put
xin the checkboxes)git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfigby runninggit config --global alias.ci "commit -s".Signed-off-by : Varsha U N varshaun58@gmail.com